Skip to content

fix: preserve exception context and return structured error responses #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arnchlmcodes wants to merge 1 commit into from
+16 −16
Closed

fix: preserve exception context and return structured error responses #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions API/Routes/Case/CaseRoute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ def copy():
"status_code": "success"
}
return(response)
except(IOError):
raise IOError
except OSError:
raise OSError
except(IOError) as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500
except OSError as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500

@case_api.route("/deleteCase", methods=['POST'])
def deleteCase():
Expand All @@ -119,8 +119,8 @@ def deleteCase():
return jsonify(response), 200
except(IOError):
return jsonify('No existing cases!'), 404
except OSError:
raise OSError
except OSError as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500

@case_api.route("/getResultData", methods=['POST'])
def getResultData():
Expand Down
20 changes: 10 additions & 10 deletions API/Routes/Upload/UploadRoute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ def backupCase():

except(IOError):
return jsonify('No existing cases!'), 404
except OSError:
raise OSError
except OSError as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500

@upload_api.route('/uploadCaseUnchunked_old', methods=['POST'])
def uploadCaseUnchunked_old():
Expand Down Expand Up @@ -402,10 +402,10 @@ def uploadCaseUnchunked_old():
}

return jsonify(response), 200
except(IOError):
raise IOError
except OSError:
raise OSError
except(IOError) as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500
except OSError as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500

def handle_full_zip(file, filepath=None):
msg = []
Expand Down Expand Up @@ -649,7 +649,7 @@ def uploadXls():
}

return jsonify(response), 200
except(IOError):
raise IOError
except OSError:
raise OSError
except(IOError) as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500
except OSError as e:
return jsonify({"error": str(e), "type": type(e).__name__}), 500