fix: Update actions to Node 24#825
Conversation
sonukapoor
left a comment
There was a problem hiding this comment.
Thanks for this Chris - Node 20 EOL was April 2025 so this was definitely overdue. One file got missed: docs-site.yml still has node-version: 22 on line 38. After this PR merges the repo would have three workflows at 24 and one at 22. Could you bump that one too, or add a comment explaining why it intentionally stays at 22?
On action.yml: bumping the default from "20" to "24" is the right direction, but it does silently upgrade the Node environment for anyone who hasn't pinned node-version in their workflow. I don't think it'll break anything - the CLI has no native addon dependency and engines is >=18 - but worth a note in the PR description so adopters are aware.
Otherwise looks good. The codebase already has @types/node: ^24.0.0 in devDependencies, so CI is now consistent with what the code is typed against.
|
@sonukapoor Thanks, I'd missed the Regarding updating the PR description I already have the note at the end about behaviour. I've updated it slightly as GitHub action runners are already forcing Node 24 regardless of if a user has it set to 20 via the current default, so only the subset of users running an unpinned version of the action on self-hosted runners aren't getting Node 24 anyway. Not sure if there's somewhere else I need to add this note? |
sonukapoor
left a comment
There was a problem hiding this comment.
Thanks for adding docs-site.yml and updating the docs table - that covers everything from the previous review. The codebase already has @types/node: ^24.0.0 in devDependencies so CI is now consistent with what the code is typed against. Good to go.
Summary
Updates actions still using Node 20 to Node 24 (Current LTS), including the Github Marketplace action, as Node 20 is past End Of Life.
Why this change
Fixes warnings and forced node version upgrade when running actions:
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
What changed
Validation
I ran both the tests and build successfully. The 3 actions mentioned are also already being force ran on Node 24 in any case, just exhibiting the warning mentioned, so have already been run many times on Node 24.
User-facing impact
Does this change:
Notes
The change in the default node version for the GitHub Marketplace action could in theory cause the action to start failing on self-hosted runners that can't run Node 24, but this would be easily fixed by updating the setting to set the version manually back to Node 20 in those cases. Where this action is running on official GitHub action runners it already forces Node 24 even if set to Node 20 or below since support has been dropped.