Fix #559 : Create an generated bullet list from a template construct#560
Merged
Conversation
… XmlValueDisconnectedException.
etraisnel2
changed the title
etraisnel2
force-pushed
the
issue559
branch
2 times, most recently
from
47337c6 to
05b035c
Compare
During numIdCopy, if numbering isn't found in template, look it up in generated doc adapt test templates for 559 back to 3.3.5 Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
Add test models Signed-off-by: Erwann Traisnel <erwann.traisnel@obeo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 559
Numbering (from bullet & number list) that is not explicitly present in the template, but are generated from html, are not taken into account in the generated document, and fails to be copied.
This causes the doc generation to crash, and no doc is generated
What is the new behavior?
Generated numbering are now taken into account.
Generation do not crash anymore when generated html contains numbering
Does this PR introduce a breaking change?
Other information