Nco/enh/templates#45
Open
ncouvert wants to merge 3 commits into
Open
Conversation
This was referenced Apr 14, 2026
lfasani
reviewed
Apr 27, 2026
ncouvert
force-pushed
the
nco/enh/templates
branch
from
3df4980 to
b2dac1c
Compare
ncouvert
force-pushed
the
nco/enh/templates
branch
from
b2dac1c to
61f5968
Compare
This was
linked to
issues
May 6, 2026
frouene
reviewed
May 18, 2026
| @Override | ||
| public boolean canHandle(String projectTemplateId) { | ||
| return PepperMMProjectTemplateProvider.PEPPERMM_EXAMPLE_TEMPLATE_ID.equals(projectTemplateId); | ||
| return PepperMMProjectTemplateProvider.PEPPERMM_EXAMPLE_TEMPLATE_ID.equals(projectTemplateId) || PepperMMProjectTemplateProvider.PEPPERMM_EMPTY_TEMPLATE_ID.equals(projectTemplateId); |
Collaborator
There was a problem hiding this comment.
Why try to combine the two into a single service? It seems clearer to me to have two separate services, each handling its own template.
Collaborator
Author
There was a problem hiding this comment.
Now have two files/services:
- PepperMMProjectTemplateInitializerSample
- PepperMMProjectTemplateInitializerEmpty
Collaborator
Author
There was a problem hiding this comment.
I may rename the files from PepperMMProjectTemplateInitializerXXX to PepperMMProjectTemplateXXXInitializer ?
ncouvert
force-pushed
the
nco/enh/templates
branch
from
61f5968 to
405360a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.