Skip to content

sweep: accept a spoken noop token when codex skips the file write#44

Merged
Octember merged 1 commit into
mainfrom
claude/stupify-status-re-reviewing-220c09
Jul 18, 2026
Merged

sweep: accept a spoken noop token when codex skips the file write#44
Octember merged 1 commit into
mainfrom
claude/stupify-status-re-reviewing-220c09

Conversation

@Octember

Copy link
Copy Markdown
Owner

codex sometimes finishes a clean review by saying STUPIFY_NO_NEW_ISSUES as its final message instead of writing it to the review file (observed on bevyl #7528, #7537, #7627 in the 2026-07-17 sweep log). The runner only reads the file, so those runs logged review FAILED and the head got throttled for FAIL_RETRY_MIN (60 min) — PRs looked ignored.

Fix: when the review file is empty but the run succeeded, parse the final codex message (the text between the last bare codex line and its tokens used footer) and accept an exact STUPIFY_NO_NEW_ISSUES match as the noop it meant to write. Only that message can stand in for the file — never the whole transcript, which inlines the untrusted diff — and a run with no tokens used footer (truncated) is still a failure.

Tested with the real transcript shape from the VM's sweep.log, plus injection and truncation cases.

codex occasionally ends with STUPIFY_NO_NEW_ISSUES as its final message
without writing the review file (seen on bevyl #7528/#7537/#7627); the
run then read as FAILED and the head was throttled for an hour. Parse
the final codex message (last 'codex' line to its 'tokens used' footer,
never the diff-bearing transcript) and treat an exact token match as
the noop it meant to write.
@Octember
Octember force-pushed the claude/stupify-status-re-reviewing-220c09 branch from c0a8747 to 5154ff8 Compare July 18, 2026 02:41

@exe-dev-github-integration exe-dev-github-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Octember
Octember merged commit 4c6766f into main Jul 18, 2026
2 checks passed
@Octember
Octember deleted the claude/stupify-status-re-reviewing-220c09 branch July 18, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant