ArgoCD: Update error message when cloning fails. #1736
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flin-8
approved these changes
Jan 28, 2026
Contributor
flin-8
left a comment
flin-8
left a comment
There was a problem hiding this comment.
LGTM
Can you add a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user specifies something other than a branch in their "target revision" we want to provide a useful error message.
Turns out - libgit2sharp will fail if we try to pass in anything other than a branch (as it prepends the branchname with "refs/remotes/origin/" - which means that anything other than a branch will fail to clone anyway.
Given this, the error message for cloning has been updated to include a query to check that targetRevision is a branch.
Fixes MD-1210