Argo Image Update Step: Remove package purpose from package filtering #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Argo Image Update step accepts a list of packages which are to be updated.
Calamari filters this list, removing any packages which are not flagged with a purpose of "DockerImageReference".
What is the risk of removing this?
Someone creates a step which has a non-docker package - this package therefore will not exist within the k8s yaml which is to be updated. So we may perform extra iterations for packages which cannot be updated (thus the step takes longer), but it will not functionally change the behaviour.
It should be noted that the step-UI prevents the inclusion of any packages which are not containers - thus 'bad' packages must be added to the step via other means (eg Terraform, via the API etc.).