Skip to content

Remove unused method, expose tentacle environment variables into Tentacle Core, and add a method for defining the tentacle home env var.#1183

Merged
LukeButters merged 2 commits intomainfrom
luke/more-shared-env-vars
Feb 12, 2026
Merged

Remove unused method, expose tentacle environment variables into Tentacle Core, and add a method for defining the tentacle home env var.#1183
LukeButters merged 2 commits intomainfrom
luke/more-shared-env-vars

Conversation

@LukeButters
Copy link
Contributor

@LukeButters LukeButters commented Feb 11, 2026

Background

Tentacle Simulator and probably the in process Tentacle have a bug where the TentacleHome directory does not match what is returned by IHomeDirectoryProvider. This causes an issue where package deltas are never sent.

This PR aims to improve the situation by making it easier to setup an in process tentacle it does this by:

  • Removing a method that is never used, and so doesn't need to be set in Tentacle Simulator or the in process Tentacle.
  • Moving the environment variables to Tentacle Core, which will allow Simulator/in-proc Tentacle to reference those rather than hard code.
  • Creating a method that defines how the TentacleHome environment variable is defined, preventing the issue seen in Tentacle Simulator. Specifically where the value of TentacleHome env var did not match what is returned by IHomeDirectoryProvider.HomeDirectory

Note: Tentacle Core is the place we have been placing the code which can be used by the In process tentacle for integration tests as well as for use by Tentacle Simulator for development. Ideally core would be enough to get a sufficiently real Tentacle.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@LukeButters LukeButters requested review from a team as code owners February 11, 2026 05:09
Copy link
Contributor

@flin-8 flin-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ for our files - USINGS changes only

Copy link
Contributor

@rhysparry rhysparry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚 LGTM

@LukeButters LukeButters merged commit aac1790 into main Feb 12, 2026
51 checks passed
@LukeButters LukeButters deleted the luke/more-shared-env-vars branch February 12, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants