Remove unused method, expose tentacle environment variables into Tentacle Core, and add a method for defining the tentacle home env var.#1183
Merged
LukeButters merged 2 commits intomainfrom Feb 12, 2026
Conversation
flin-8
approved these changes
Feb 11, 2026
Contributor
flin-8
left a comment
There was a problem hiding this comment.
✅ for our files - USINGS changes only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Tentacle Simulator and probably the in process Tentacle have a bug where the
TentacleHomedirectory does not match what is returned byIHomeDirectoryProvider. This causes an issue where package deltas are never sent.This PR aims to improve the situation by making it easier to setup an in process tentacle it does this by:
TentacleHomeenvironment variable is defined, preventing the issue seen in Tentacle Simulator. Specifically where the value ofTentacleHomeenv var did not match what is returned byIHomeDirectoryProvider.HomeDirectoryNote: Tentacle Core is the place we have been placing the code which can be used by the In process tentacle for integration tests as well as for use by Tentacle Simulator for development. Ideally core would be enough to get a sufficiently real Tentacle.
How to review this PR
Quality ✔️
Pre-requisites