ci: run test suite on pull requests#21
Merged
Merged
Conversation
deploy.yml only tests post-merge (on push to main/release), so PRs showed no checks and every bump looked equally safe. This runs the same dotnet + npm tests on each PR so breakage surfaces before merge, not after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/ci.ymlthat runs the test suite on every PR tomain/release.Why
deploy.ymlonly runs tests on push to main/release (post-merge), so PRs report no checks — every Dependabot bump looks equally safe, and breakage only surfaces after it's already on main. This runs the samedotnet test+npm teston the PR, so a red check blocks a bad merge instead of catching it post-merge.Same steps as deploy.yml's
testjob; deploy.yml is unchanged (still re-tests before deploying). Concurrency cancels superseded runs on the same PR.Test
This PR's own
cicheck exercises the workflow (apull_requestworkflow runs from the PR branch).