test: silence Testcontainers 4.13 obsolete PostgreSqlBuilder() ctor#22
Merged
Conversation
4.13 deprecated the parameterless builder; pass the image to the constructor instead of via .WithImage(). No behavior change, 28/28 integ tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
new PostgreSqlBuilder("postgres:15-alpine")instead ofnew PostgreSqlBuilder().WithImage("postgres:15-alpine")inPostgresFixture.Why
Testcontainers.PostgreSql 4.13 (merged in #18) deprecated the parameterless
PostgreSqlBuilder()constructor (CS0618); it's slated for removal in a future major. The image now goes to the constructor. Surfaced by the new pre-merge CI on the 4.13 bump.Test
dotnet build -c Release— CS0618 gone.dotnet test— 28/28 pass. Pre-merge CI on this PR re-verifies.