Add programPrepare and programRequiresPrepare wasm imports #4013
+121
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
commented
Nov 14, 2025
bragaigor
force-pushed
the
braga/program-prepare-arbitrator
branch
from
2fb49b5 to
fcc1383
Compare
bragaigor
force-pushed
the
braga/program-prepare-arbitrator
branch
from
fcc1383 to
5355d3f
Compare
rauljordan
previously approved these changes
Dec 5, 2025
Contributor
rauljordan
left a comment
rauljordan
left a comment
There was a problem hiding this comment.
The changes are pretty straightforward, LGTM
tsahee
requested changes
Dec 9, 2025
arbos/programs/programs.go
Outdated
| statedb.AddStylusPages(program.footprint) | ||
| defer statedb.SetStylusPagesOpen(open) | ||
|
|
||
| handleProgramPrepare(statedb, moduleHash, contract.Address(), contract.Code, contract.CodeHash, params.MaxWasmSize, params.PageLimit, evm.Context.Time, debugMode, program, runCtx) |
Contributor
There was a problem hiding this comment.
let's take it one small step forward:
- have handleProgramPrepare return localAsm []byte.
- have the native implementation be current lines 230.. 238 that calls getCompiledProgram and extracts just the correct impl from the map
- remove getCompiledProgram from the wasm implementation and replace it with what you currently have for handleProgramPrepare + return nil
Contributor
Author
There was a problem hiding this comment.
Done in 8d0988e . I kept the current panic in case getCompiledProgram returns an error. Let me know if we prefer handleProgramPrepare to return an error instead.
bragaigor
force-pushed
the
braga/program-prepare-arbitrator
branch
from
6be417c to
c661d08
Compare
tsahee
added
the
after-next-version
Contributor
|
labeling it after-next-version, by which I mean after arbos 52 with customDA support |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4013 +/- ##
==========================================
+ Coverage 33.35% 35.15% +1.80%
==========================================
Files 453 453
Lines 55536 55539 +3
==========================================
+ Hits 18524 19527 +1003
+ Misses 33774 32566 -1208
- Partials 3238 3446 +208 |
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
ProgramPrepare needs the same parameters as handleProgramPrepare so we could either move ProgramPrepare closer to handleProgramPrepare or inside of it. In light that ProgramPrepare can update in the future we move it closer to handleProgramPrepare Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Update handleProgramPrepare() to return localAsm []byte Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
bragaigor
force-pushed
the
braga/program-prepare-arbitrator
branch
from
e2e3c58 to
63fc9b7
Compare
Contributor
Author
|
Added required changelog file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NIT-4074
Adds 2 new wasm imports:
programPrepareprogramRequiresPrepareprogram_requires_prepare:Arguments:
Returns:
booleanCalled just beforecall to
newProgram.Jit/arbitrator implementation: always return false
program_prepare:Arguments:
Returns: nothing
Only called if
program_requires_preparereturnstrue.Arbitrator / jit implementation: nop
In order to make implementation easier and more maintainable we create a
handleProgramPrepareso that we can get access to all parametersprogram_preparerequires.