feat: make execution client keepalive interval configurable #4140
Conversation
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
thank you for this contribution; please also add a short note to the PR description what exactly configuration flag was added, what is the default value and what it does - this will help us when creating release notes later
|
@pmikolajczyk41 Done sir |
|
@bobtajson you have removed closing curly bracket in the file |
Oh sorry, i missed it, thank you! |
|
@pmikolajczyk41 @eljobe Sorry, can you check please? What's wrong with CI? |
util/rpcclient/rpcclient.go
Outdated
| "github.com/offchainlabs/nitro/util/signature" | ||
| ) | ||
|
|
||
| const DefaultExecKeepAliveInterval = time.Minute |
There was a problem hiding this comment.
Extraneous, put time.Minute directly in TestClientConfig and DefaultClientConfig
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4140 +/- ##
==========================================
- Coverage 33.35% 33.31% -0.05%
==========================================
Files 453 453
Lines 55536 55539 +3
==========================================
- Hits 18524 18501 -23
- Misses 33774 33832 +58
+ Partials 3238 3206 -32 |
|
@pmikolajczyk41 so sir, i made changes @joshuacolvin0 asked me, should i change something else or revert changes? |
|
@bobtajson we are waiting for @joshuacolvin0 revisit here, especially for his take on my comment in any way you'll need to add a changelog fragment, according to our updated |
4 participants
Summary
Makes the execution client keepalive interval configurable instead of being hardcoded to 1 minute.
Resolves TODO in
validation_client.goAdded flag:
--validation-server-configs.exec-keep-alive-intervalDefault value:
1m(1 minute)Purpose: Controls the interval for sending keepalive messages to execution client runs to maintain active connections.