[NIT-4242] Add initial L1 base fee to node configuration #4171

pmikolajczyk41 · 2025-12-23T14:20:20Z

Move arbostypes.DefaultInitialL1BaseFee to go-ethereum/params
Extend L2Config with InitialL1BaseFee field. Since the fee might exceed 1<<64, the field type is string and we have a getter InitialL1BaseFeeParsed that returns:

DefaultInitialL1BaseFee when the string is empty or it cannot be parsed in decimal system
parsed value (in decimal system)

In the cmd/nitro/init.go resolve† the initial L1 base fee from either CLI flag or genesis configuration. Ensure it matches what was in the parsed init message on the parent chain.

† config resolution:

in case genesis.json is absent, use the --chain.initial-l1base-fee flag value
in case genesis.json is present and --chain.initial-l1base-fee is not empty, ensure the values match
use genesis.json

closes NIT-4242
pulls in OffchainLabs/go-ethereum#603

codecov · 2025-12-23T14:56:58Z

Codecov Report

❌ Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.14%. Comparing base (416e512) to head (e6feb25).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   33.01%   33.14%   +0.13%     
==========================================
  Files         459      459              
  Lines       55830    55853      +23     
==========================================
+ Hits        18430    18512      +82     
+ Misses      34185    34091      -94     
- Partials     3215     3250      +35

github-actions · 2025-12-23T15:35:48Z

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
4458	3	4455	0

View the top 3 failed tests by shortest run time

TestSetLatestSnapshotUrl

Stack Traces | 0.120s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
    init_test.go:300: running test case latest file with http url
INFO [12-30|19:05:01.958] Set latest snapshot url                  url=http://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case latest file with https url
INFO [12-30|19:05:01.961] Set latest snapshot url                  url=https://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case chain and contents with upper case
INFO [12-30|19:05:01.963] Set latest snapshot url                  url=http://127.0.0.1:36257/arb1/2024/21/archive.tar.gz
    init_test.go:353: goroutine 47 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2e5f6f0, 0xc0003f6e00}, {0x2e32400, 0x41b4460}, {0xc000707bb0, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/cmd/nitro.Require(0xc0003f6e00, {0x2e32400, 0x41b4460}, {0xc000707bb0, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/cmd/nitro/config_test.go:378 +0x5d
        github.com/offchainlabs/nitro/cmd/nitro.startFileServer.func2()
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:353 +0xa5
        created by github.com/offchainlabs/nitro/cmd/nitro.startFileServer in goroutine 67
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:350 +0x285
        
    init_test.go:353: �[31;1m [failed to shutdown server] context canceled �[0;0m
--- FAIL: TestSetLatestSnapshotUrl (0.12s)

TestAnyTrustRekey

Stack Traces | 52.880s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x43fe870, 0xc000232a80}, {0x43bb140, 0xc20ac968a0}, {0xc0ba3ad310, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/system_tests.Require(0xc000232a80, {0x43bb140, 0xc20ac968a0}, {0xc0ba3ad310, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2034 +0x5d
        github.com/offchainlabs/nitro/system_tests.(*NodeBuilder).BuildL2OnL1(0xc0004b39e0, 0xc000232a80)
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:909 +0x5ae
        github.com/offchainlabs/nitro/system_tests.TestAnyTrustRekey(0xc000232a80)
        	/home/runner/work/nitro/nitro/system_tests/anytrust_test.go:162 +0xeaa
        testing.tRunner(0xc000232a80, 0x4039b08)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:909: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 2 state: 3 �[0;0m
--- FAIL: TestAnyTrustRekey (52.88s)
ERROR[12-30|17:06:12.261] Delayed sequencer error                  err="context canceled"
�[34;1mInitial values�[0;0m
�[34;1m    L1 base fee 1886566592�[0;0m
�[34;1m    L1 estimate 5000000000�[0;0m

TestFastConfirmationWithSafe

Stack Traces | 71.710s run time

=== RUN   TestFastConfirmationWithSafe
=== PAUSE TestFastConfirmationWithSafe
=== CONT  TestFastConfirmationWithSafe
    common_test.go:711: BuildL1 deployConfig: DeployBold=false, DeployReferenceDAContracts=false
ERROR[12-30|17:06:18.769] latest L1 block is old                   l1Block=0 l1Timestamp=1970-01-01T00:00:00+0000 age=490865h6m18.769666178s
    common_test.go:1181: �[31;1m [bridging failed] �[0;0m
--- FAIL: TestFastConfirmationWithSafe (71.71s)
ERROR[12-30|17:07:15.101] Error getting finality msg count         scenario=safe err="context canceled"

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

go.mod

bragaigor · 2025-12-24T11:28:03Z

LGTM

diegoximenes

As you mentioned in a meeting, since there are multiple valid ways to serialize chain config, in order to Execution build parsedInitMessage only through its local config, users will also need to have a way to provide the serialized chain config.
This can be done in this PR, a new PR, or even a new linear task can be created for that, up to you to decide the best path to move forward 🙂

cmd/conf/chain.go

cmd/nitro/init.go

arbos/arbostypes/incomingmessage.go

…-basefee

…parse failure

pmikolajczyk41 · 2025-12-29T12:07:32Z

@diegoximenes regarding serialized chain config I'd go with another linear ticket (I'm about to create it)

cmd/conf/chain.go

cmd/nitro/init.go

arbos/arbostypes/incomingmessage.go

…-basefee

diegoximenes · 2025-12-31T23:27:48Z

cmd/conf/chain.go

+	Name             string                   `koanf:"name"`
+	InfoFiles        []string                 `koanf:"info-files"`
+	InfoJson         string                   `koanf:"info-json"`
+	InitialL1BaseFee string                   `koanf:"initial-l1base-fee"`


Something that I didn't notice in previous reviews.
This flag will be better placed at the InitConfig instead of L2Config.

pmikolajczyk41 added 2 commits December 23, 2025 15:19

Add initial L1 base fee to configuration

08a034f

Maintain backwards compatibility

aa8d609

pmikolajczyk41 mentioned this pull request Dec 23, 2025

params: Add initial L1 base fee to configuration OffchainLabs/go-ethereum#603

Open

Add changelog fragment

e1af47f

pmikolajczyk41 marked this pull request as ready for review December 23, 2025 15:20

pmikolajczyk41 requested review from bragaigor, diegoximenes and tsahee December 23, 2025 15:21

pmikolajczyk41 assigned diegoximenes Dec 23, 2025

bragaigor reviewed Dec 23, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Remove weird logging import

5d9554c

pmikolajczyk41 requested a review from bragaigor December 24, 2025 07:20

bragaigor previously approved these changes Dec 24, 2025

View reviewed changes

diegoximenes requested changes Dec 24, 2025

View reviewed changes

diegoximenes assigned pmikolajczyk41 and unassigned diegoximenes Dec 24, 2025

pmikolajczyk41 added 8 commits December 29, 2025 11:53

Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-4242…

0b10c1d

…-basefee

Use initial-l1base-fee in the error message. Return error in case of …

4947189

…parse failure

Remove comment for an internal function

b551c41

Rename chainconfig to l2config

1da2801

Compare correct values

831559b

Fix error message

8f4ebde

Consistent flag naming

d8bed9c

Add test

800bf40

pmikolajczyk41 dismissed bragaigor’s stale review via 800bf40 December 29, 2025 11:44

pmikolajczyk41 added 2 commits December 29, 2025 13:06

Lint

ccde747

Lint

eb67288

pmikolajczyk41 requested review from bragaigor and diegoximenes December 29, 2025 12:07

pmikolajczyk41 assigned diegoximenes and unassigned pmikolajczyk41 Dec 29, 2025

diegoximenes requested changes Dec 30, 2025

View reviewed changes

cmd/conf/chain.go Outdated Show resolved Hide resolved

cmd/conf/chain.go Outdated Show resolved Hide resolved

cmd/nitro/init.go Outdated Show resolved Hide resolved

cmd/nitro/init.go Outdated Show resolved Hide resolved

arbos/arbostypes/incomingmessage.go Show resolved Hide resolved

diegoximenes assigned pmikolajczyk41 and unassigned diegoximenes Dec 30, 2025

pmikolajczyk41 added 5 commits December 30, 2025 17:30

Remove note about backwards compatibility

608dd3a

Remove log, improve error message

01e9108

Rename variables

f68447d

Add "flag" to error message

41de374

Merge remote-tracking branch 'origin/master' into pmikolajczyk/nit-4242…

e6feb25

…-basefee

pmikolajczyk41 assigned diegoximenes and unassigned pmikolajczyk41 Dec 30, 2025

pmikolajczyk41 requested a review from diegoximenes December 30, 2025 16:43

diegoximenes approved these changes Dec 31, 2025

View reviewed changes

diegoximenes assigned tsahee and unassigned diegoximenes Dec 31, 2025

diegoximenes requested changes Dec 31, 2025

View reviewed changes

diegoximenes assigned pmikolajczyk41 and unassigned tsahee Dec 31, 2025

[NIT-4242] Add initial L1 base fee to node configuration #4171

Are you sure you want to change the base?

[NIT-4242] Add initial L1 base fee to node configuration #4171

Uh oh!

Conversation

pmikolajczyk41 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 3 Tests Failed:

Uh oh!

Uh oh!

bragaigor commented Dec 24, 2025

Uh oh!

diegoximenes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pmikolajczyk41 commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diegoximenes Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pmikolajczyk41 commented Dec 23, 2025 •

edited

Loading

codecov bot commented Dec 23, 2025 •

edited

Loading

github-actions bot commented Dec 23, 2025 •

edited

Loading

diegoximenes left a comment •

edited

Loading

diegoximenes Dec 31, 2025 •

edited

Loading