fix: handle target starting with colon in RelativeTestTargetPath #16181
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix edge case where targets starting with ':' (e.g., ":bar") were incorrectly returned as-is instead of empty string. The condition last > 0 missed the case when colon is at position 0, causing invalid paths when used in path.Join operations.
Fix edge case in `RelativeTestTargetPath()` for Bazel targets starting with `:`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Fixes a bug in
RelativeTestTargetPath()where Bazel targets starting with:(e.g.,":bar") were incorrectly returned as-is instead of an empty string. The conditionlast > 0missed the edge case when the colon is at position 0, which could cause invalid paths when used inpath.Join()operations withinTestDataPath().The fix adds explicit handling for targets starting with
:, returning an empty string to represent the current package, which is the correct behavior for such targets in Bazel.Which issues(s) does this PR fix?
Fixes # (no issue filed - small bug fix)
Other notes for review
go test -tags=bazel ./build/bazel/...)":bar","//:bar", and standard formats like"//pkg/cmd/foo:bar"Acknowledgements