Add Laravel 13 support#8
Conversation
- Update illuminate/contracts constraint to include ^13.0 - Add Laravel 12 and 13 to CI test matrix with corresponding testbench and carbon versions
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the package's compatibility by adding support for Laravel 13. It updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the illuminate/contracts dependency to add support for Laravel 13. The change is functionally correct, but I have provided a suggestion to simplify the version constraint in composer.json for better readability and future maintainability.
| "require": { | ||
| "php": "^8.3", | ||
| "illuminate/contracts": "^10.0|^11.0|^12.0" | ||
| "illuminate/contracts": "^10.0|^11.0|^12.0|^13.0" |
There was a problem hiding this comment.
For better readability and easier maintenance, you can simplify this version constraint. Instead of listing each major version with |, you can use a range constraint. This is equivalent to the current constraint but is more concise and easier to update for future versions.
| "illuminate/contracts": "^10.0|^11.0|^12.0|^13.0" | |
| "illuminate/contracts": ">=10.0 <14.0" |
pest-plugin-laravel v4 (which supports Laravel 13) requires Pest v4, pest-plugin-arch v4, and collision ^8.9. Also add testbench ^11.0.
testbench 10.0 has a bug with package:discover when using prefer-lowest
testbench package:discover fails with prefer-lowest on L12/L13 due to incompatible minimum dependency versions
|
[claude] PR review — comment PR pulita: aggiunge ^13.0 a illuminate/contracts ed estende la matrice CI a Laravel 12 e 13 con le coppie testbench/carbon corrette. Due osservazioni non bloccanti: il constraint di nunomaduro/collision potrebbe essere troppo stretto per testbench 11, e l'esclusione di prefer-lowest per 12/13 elimina la validazione del lower bound dichiarato. |
| "pestphp/pest": "^3.8", | ||
| "pestphp/pest-plugin-arch": "^3.1", | ||
| "pestphp/pest-plugin-laravel": "^3.2", | ||
| "nunomaduro/collision": "^8.9", |
There was a problem hiding this comment.
nunomaduro/collision e' bloccato a ^8.9 ma testbench 11 (Laravel 13) richiede collision ^9.0. Su prefer-stable con laravel 13.* la risoluzione potrebbe fallire. Allineare a ^8.9|^9.0.
| laravel: [11.*] | ||
| laravel: [11.*, 12.*, 13.*] | ||
| stability: [prefer-lowest, prefer-stable] | ||
| exclude: |
There was a problem hiding this comment.
Escludere prefer-lowest per 12.* e 13.* significa non validare mai il bound minimo dichiarato per quelle versioni: una bump non compatibile in transitive deps passerebbe inosservata. Se lo scopo era evitare conflitti pest 3.x, valuta di tenere prefer-lowest almeno su Laravel 13.
Summary
illuminate/contractsconstraint incomposer.jsonto include^13.0.github/workflows/run-tests.ymlwith correspondingorchestra/testbenchandnesbot/carbonversionsNotes
^8.3requirement is already satisfied (Laravel 13 requires PHP 8.3+)ServiceProvider, basic PHP constructs)Test plan
composer installresolves correctly withilluminate/contracts:^13.0