Skip to content

Add Laravel 13 support#8

Open
mirchaemanuel wants to merge 4 commits into
mainfrom
feature/laravel-13-support
Open

Add Laravel 13 support#8
mirchaemanuel wants to merge 4 commits into
mainfrom
feature/laravel-13-support

Conversation

@mirchaemanuel

Copy link
Copy Markdown
Member

Summary

  • Updated illuminate/contracts constraint in composer.json to include ^13.0
  • Added Laravel 12 and 13 entries to the CI test matrix in .github/workflows/run-tests.yml with corresponding orchestra/testbench and nesbot/carbon versions

Notes

  • PHP ^8.3 requirement is already satisfied (Laravel 13 requires PHP 8.3+)
  • No deprecated Laravel APIs found in the codebase; source code uses only stable APIs (ServiceProvider, basic PHP constructs)

Test plan

  • CI passes for Laravel 11, 12, and 13 on both PHP 8.3 and 8.4
  • Verify composer install resolves correctly with illuminate/contracts:^13.0

- Update illuminate/contracts constraint to include ^13.0
- Add Laravel 12 and 13 to CI test matrix with corresponding
  testbench and carbon versions
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the package's compatibility by adding support for Laravel 13. It updates the composer.json file to allow installation with Laravel 13 and modifies the CI configuration to include tests for Laravel versions 12 and 13, ensuring continued compatibility and stability.

Highlights

  • Laravel 13 Support: This PR adds support for Laravel 13 by updating the illuminate/contracts dependency in composer.json.
  • CI Test Matrix Update: The CI test matrix in .github/workflows/run-tests.yml has been updated to include Laravel 12 and 13, along with corresponding orchestra/testbench and nesbot/carbon versions.
  • PHP Version Compatibility: The existing PHP ^8.3 requirement already satisfies Laravel 13's requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/run-tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the illuminate/contracts dependency to add support for Laravel 13. The change is functionally correct, but I have provided a suggestion to simplify the version constraint in composer.json for better readability and future maintainability.

Comment thread composer.json
"require": {
"php": "^8.3",
"illuminate/contracts": "^10.0|^11.0|^12.0"
"illuminate/contracts": "^10.0|^11.0|^12.0|^13.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and easier maintenance, you can simplify this version constraint. Instead of listing each major version with |, you can use a range constraint. This is equivalent to the current constraint but is more concise and easier to update for future versions.

Suggested change
"illuminate/contracts": "^10.0|^11.0|^12.0|^13.0"
"illuminate/contracts": ">=10.0 <14.0"

pest-plugin-laravel v4 (which supports Laravel 13) requires Pest v4,
pest-plugin-arch v4, and collision ^8.9. Also add testbench ^11.0.
testbench 10.0 has a bug with package:discover when using prefer-lowest
testbench package:discover fails with prefer-lowest on L12/L13 due to
incompatible minimum dependency versions
@amargiovanni

Copy link
Copy Markdown

[claude] PR review — comment

PR pulita: aggiunge ^13.0 a illuminate/contracts ed estende la matrice CI a Laravel 12 e 13 con le coppie testbench/carbon corrette. Due osservazioni non bloccanti: il constraint di nunomaduro/collision potrebbe essere troppo stretto per testbench 11, e l'esclusione di prefer-lowest per 12/13 elimina la validazione del lower bound dichiarato.

@amargiovanni amargiovanni left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[claude] PR review — inline

Comment thread composer.json
"pestphp/pest": "^3.8",
"pestphp/pest-plugin-arch": "^3.1",
"pestphp/pest-plugin-laravel": "^3.2",
"nunomaduro/collision": "^8.9",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nunomaduro/collision e' bloccato a ^8.9 ma testbench 11 (Laravel 13) richiede collision ^9.0. Su prefer-stable con laravel 13.* la risoluzione potrebbe fallire. Allineare a ^8.9|^9.0.

laravel: [11.*]
laravel: [11.*, 12.*, 13.*]
stability: [prefer-lowest, prefer-stable]
exclude:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Escludere prefer-lowest per 12.* e 13.* significa non validare mai il bound minimo dichiarato per quelle versioni: una bump non compatibile in transitive deps passerebbe inosservata. Se lo scopo era evitare conflitti pest 3.x, valuta di tenere prefer-lowest almeno su Laravel 13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants