Fix dashboard credentials view stuck on "Loading credentials…"#104
Merged
Conversation
The background credential load cleared its status message only on error. A successful load — including an empty list (node has no credentials registered) — left the transient "Loading credentials…" message lingering until the next keypress, so the view looked stuck. Clear the status on the success path too. Test: dashboard asserts an empty list shows the empty-state hint and no longer shows a loading status. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where opening a node's git-credential view in the dashboard TUI left the status stuck on “Loading credentials…” forever when the node had no credentials registered (and, more generally, on any successful background load).
The background load cleared its status only on the error path; a successful load — including an empty list — never cleared the transient message, and since the load completes without a keypress, nothing else cleared it either. Now the success path clears the status, so the view shows the credentials (or the empty-state hint) with no lingering loading message.
Test plan
dart analyze+dart format --set-exit-if-changed .— clean.🤖 Generated with Claude Code