Sudheesh-Student Profile Educational Progress#1908
Sudheesh-Student Profile Educational Progress#1908SudheeshTD wants to merge 13 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Hi Sudeesh,
I have reviewed your PR locally, few comments:
1 - it would be great if you could mention under what are they stored in the db as one of them was Tasks in requirement and you have stored it in studenttask and couldn't locate Students and StudentProgress in DB.
2 - i was not able to retrieve any response for all subject id's except '68def3a5f0844c6916607a94' in the API call: ../student/profile/subject/:id


|
Hi @Anusha-Gali, |
Hi Sudheesh, i was talking about the point - "DB Fields required", i couldn't find them in mongoDB and the one's i found have different name when compared to the suggested one's |
Hi @Anusha-Gali , And for reference, Student is taken from the UserProfile Model, subjects is taken from subjects model from Database, Student tasks is taken from educationtasks model, and the student progress is within the Get Student profile controller. Can you test the feature now, I have updated the code for getSubjectDetails. |
|
Hi @Anusha-Gali , Can you please check now, the previous commit didn't have the changes, so you were not able to see the modifications. Can you Please check now. |
Hello @Anusha-Gali , I am able to test it still without any issue, after doing a fresh pull. I wanted to check if the pull you did was the most recent one.
video1067019561.mp4 |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi @SudheeshTD ,
Thank you so much for the video. Please find attached the video of me testing and i am still not able to. I can maybe try cloning directly and testing but in the mean time, i think it's best if someone else also tries to review the PR.
1908.mp4
Hi @Anusha-Gali, There is a small changes you have to do when logging in. |
850edde to
e2612de
Compare
|












Description
Related PRS (if any):
This Backend PR is related to the #4420 Frontend PR.
To test this feature you need to checkout both backend and frontend PR #4420.
…
Main changes explained:
…
How to test:
check into current branch and the frontend branch #4420
do
npm installand...to run this PR locallyClear site data/cache
Log in as the user specified in video, or message me in the slack, for details. Use only that user to see data in the student profile page.
Follow the frontend PR to follow along in testing.
Screenshots or videos of changes:
video2260393348.mp4
Note:
Include the information the reviewers need to know.