Skip to content

Linh - Fix edit/save functionality in Weekly Summary Email for Admins#3927

Open
linh2020 wants to merge 3 commits intodevelopmentfrom
linh_fix_weekly_summary_email_update
Open

Linh - Fix edit/save functionality in Weekly Summary Email for Admins#3927
linh2020 wants to merge 3 commits intodevelopmentfrom
linh_fix_weekly_summary_email_update

Conversation

@linh2020
Copy link

@linh2020 linh2020 commented Aug 20, 2025

…stants to resolve task issues

Description

image

This PR addresses issues reported in the Weekly Company Summary Email for Admins feature, originally introduced in PR #3671
The main issue was that edited email addresses were not being updated immediately after saving changes. This PR fixes that behavior and ensures that changes are reflected in the recipient list without requiring a manual refresh.

Related PRS (if any):

This frontend PR is related to the backend PR OneCommunityGlobal/HGNRest#1478

Main changes explained:

  • Fixed edit and save functionality in Weekly Summary Email popup so changes are reflected immediately.
  • Updated state handling to ensure the recipient list re-renders after email updates.
  • Adjusted WeeklySummaryEmailAssignment.js, weeklySummaryEmailBCCAction.js, and WeeklySummaryEmailBccConstants.js to properly manage updated recipients.
  • Retained full dark mode support from earlier PR.
  • Minor cleanup to prevent duplicate recipients and improve consistency.

How to test:

  1. Checkout this branch locally.
  2. Run npm install and npm run start:local
  3. Clear site data/cache and Log in as an Admin user.
  4. Navigate to: http://localhost:3000/weekly-summary
  5. Click the Weekly Summary Email button.
  6. Edit existing recipient emails → Save.
    Confirm the updated email appears instantly in the list.
  7. Add new recipients, test deleting/editing, and confirm changes persist.
  8. Test in dark mode to ensure UI consistency.

Screenshots or videos of changes:

image

Note:

This PR fixes the edit + save bug identified in the last developer’s PR.
All tests (npm test) and lint checks pass locally.

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 314b205
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/699e9dc02167780008e44387
😎 Deploy Preview https://deploy-preview-3927--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linh2020 linh2020 changed the title Linh - fix(weekly-summary-email): update Assignment, BCC Action, and Bcc Con… Linh - fix weekly summary email admins Aug 20, 2025
@linh2020 linh2020 changed the title Linh - fix weekly summary email admins Linh - Fix weekly summary email admins issues Aug 20, 2025
@linh2020 linh2020 changed the title Linh - Fix weekly summary email admins issues Linh - Fix edit/save functionality in Weekly Summary Email for Admins Aug 20, 2025
@JERRRRY
Copy link

JERRRRY commented Aug 22, 2025

I tested the filter, add button, and edit/delete button — everything works fine. One small suggestion: in dark mode, the title 'Set Weekly Summary Email Recipients' is hard to see, so it would be better to adjust its color for better visibility.
Screenshot 2025-08-22 at 5 36 53 PM

Copy link

@Naveen-Kumar-Reddy-27 Naveen-Kumar-Reddy-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigated to Weekly Summary → clicked Weekly Summary Email.
Verified editing, saving, adding, and deleting recipient emails → all changes persisted correctly.
Tested in both light and dark mode → functionality works fine.

Observation:
In dark mode, the text “Set Weekly Summary Email Recipients” is hard to read due to low contrast.
Everything else is working as expected.
PR 3927_dark

PR 3927_edit PR 3927_light

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Linh,

I have reviewed your PR locally and though the functionality work in light mode however in dark mode, the whole page is still in light mode and the main functionality though is well adjusted to dark mode, the title isn't. Also on a side note: is the backend working cause i do not see my name in the db.

Image Image Image Image

Issues
Image
Image
Screenshot 2026-02-05 at 11 34 28 PM

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Feb 22, 2026
@linh2020 linh2020 force-pushed the linh_fix_weekly_summary_email_update branch from 7377c5e to bef8409 Compare February 24, 2026 02:05
@linh2020
Copy link
Author

Hi Linh,

I have reviewed your PR locally and though the functionality work in light mode however in dark mode, the whole page is still in light mode and the main functionality though is well adjusted to dark mode, the title isn't. Also on a side note: is the backend working cause i do not see my name in the db.

Image Image Image Image
Issues Image Image Screenshot 2026-02-05 at 11 34 28 PM


Ahh got it — you’re referring to the modal header title.

I just pulled the latest dev branch and ran it locally, and dark mode is now displaying correctly (including the title). I’ve attached a screenshot from my side for reference. It might have been an older build or cached styles when you tested — could you pull the latest changes and rebuild once to confirm?

For the backend, I’m still debugging the DB write flow, so that’s why your name isn’t appearing yet — I’ll have it fixed soon.

2026-02-23 21_07_51-Greenshot 2026-02-23 21_08_00-Greenshot

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants