Mani shashank; fix/BM Dashboard Financials Tracking, Cost-prediction#4193
Mani shashank; fix/BM Dashboard Financials Tracking, Cost-prediction#4193shashankm9 wants to merge 9 commits intodevelopmentfrom
Conversation
… charts, and tidy code
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi Mani Shashank, |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Mani Shashank,
I have reviewed your PR locally and have identified many issues. I have mentioned them here as well as attached screenshots for each.
- Duplicate imports is causing the code to not run. Upon commenting them myself i was able to test the code but i suppose this should not be the case
- In the light mode and dark mode - In Labor and Time Tracking - In Distribution of Labor Hours pie chart, upon selection any item and clicking on submit, the page reloads and all steps are lost.
- In the light mode and dark mode - In Financial Tracking - The pie chart fail to load.
- The UI of the titles and subtitles is not visible in Dark Mode.
Issue 1. Duplicate imports is causing the code to not run. Upon commenting them myself i was able to test the code but i suppose this should not be the case

Issue 2: In the light mode and dark mode - In Labor and Time Tracking - In Distribution of Labor Hours pie chart, upon selection any item and clicking on submit, the page reloads and all steps are lost.
4194.mp4
Issue 3: In the light mode and dark mode - In Financial Tracking - The pie chart fail to load.

** Issue 2,3,4: The UI of the titles and subtitles is not visible in Dark Mode.**

bhanuanishakkineni
left a comment
There was a problem hiding this comment.
Hello Shashank,
I have reviewed the PR and tested it. While running the frontend app, I encountered errors due to redundant import statements in router.jsx.

After I commented out those import statements in router.jsx and tried to re-run the app, it worked.
In the totalconstructionsummary page, the pie charts - Actual expenditure and Planned Expenditure were displayed and the projects drop down is working fine. Cost prediction charts rendered correctly.
First issue with this is the page is not responsive. In the smaller screens (mobile screen) only pie charts are visible and rest of the charts are going out of the screen and are not visible at all. Second issue is that some text is not visible or readable in dark mode. Change the text color so that it will be visible during dark mode.
In cost-prediction, the planned vs actual costs tracking plot is working fine and is responsive in both light and dark mode.
PR.4193+.1797.testing-1.mp4
Shravan-neelamsetty
left a comment
There was a problem hiding this comment.
Hi Mani Shashank, I tested this PR locally after fixing the duplicate imports in src/routes.jsx by commenting out lines 149-167. I navigated to /bmdashboard/totalconstructionsummary and tested both the "Labor and Time Tracking" and "Financials Tracking" sections. The Labor and Time Tracking section works properly in light mode with the Distribution of Labor Hours pie chart and Paid Labor Cost bar chart displaying correctly with all filters functioning. The Planned vs Actual Costs Tracking line chart in the Financials Tracking section also renders correctly with Labor Cost and Materials Cost filters working as expected. However, I noticed a dark mode visibility issue: the section titles "Distribution of Labor Hours" and "Paid Labor Cost" are not clearly visible in dark mode, making it difficult to read the headers. The pie charts in the left side of Financials Tracking still show "Failed to load projects" error.






Ganesh112001
left a comment
There was a problem hiding this comment.
I attempted to test PR #4193, which restores the Financials Tracking functionality in the BM Dashboard by fixing the "Failed to load projects" error and implementing expenditure pie charts. After checking out both the frontend branch (fix/bm-expenditure-charts) and backend branch (fix/bm-expenditure-api), I encountered build errors that prevented the frontend dev server from starting. The build fails with "Transform failed with 13 errors" due to duplicate identifier declarations in src/routes.jsx, where symbols RentalChart, CreateNewTeam, CPProtectedRoute, CPLogin, CPDashboard, and EventParticipation are imported or declared multiple times on lines 149, 150, 152, 155, 156, and 165. These duplicate declarations cause compilation errors that block the application from running. The code issues need to be resolved before testing can proceed.
|
Hi @shashankm9 Cost Prediction: Working correctly in both modes (video review attached). Untitled.mp4Total Construction Summary: Not working—shows “Failed to load projects” (screenshots attached). |
- Created FinancialsTrackingCard component with project dropdown - Created ExpenditureChart component with Actual/Planned pie charts - Added mock data from MongoDB expenditurePie collection - Implemented dark mode support and responsive design - Fixed legend overflow and dropdown visibility issues - Fixed Cost Prediction chart line connectivity with connectNulls prop
4dcb691 to
9bca7ea
Compare
|

















Description
This PR restores the missing Financials Tracking functionality in the BM Dashboard that was showing "Failed to load projects" error. The expenditure pie charts and cost prediction features are now fully functional with proper authentication and CSS modules implementation.

Related PRS (if any):
This frontend PR is related to the #1797 backend PR.
Main changes explained:
/api/bm/expenditure/:projectId/pieHow to test:
npm installand...to run this PR locallyhttp://localhost:5173/bmdashboard/cost-predictionScreenshots or videos of changes:
Recording.2025-10-09.215401.mp4
Note: