Skip to content

Sriamsh - Add Previous Logs preview panel to Daily Equipment Log#4655

Open
Sriamshreddy000 wants to merge 2 commits intodevelopmentfrom
sriamsh_previous_logs_panel_daily_equipment
Open

Sriamsh - Add Previous Logs preview panel to Daily Equipment Log#4655
Sriamshreddy000 wants to merge 2 commits intodevelopmentfrom
sriamsh_previous_logs_panel_daily_equipment

Conversation

@Sriamshreddy000
Copy link
Contributor

Description

Screenshot 2025-12-25 at 4 09 58 PM

Related PRS (if any):

To test this frontend PR you need to checkout the Development branch of backend.

Main changes explained:

  • Updated EDailyActivityLog.jsx to integrate Daily Activity Log data rendering based on selected date filters.
  • Added a collapsible “Previous Logs” panel under the Daily Equipment Log table.
  • Implemented state and effects to derive previous log entries based on selected date and project.
  • Mapped existing equipment data into a simplified log structure for display.
  • Added empty-state handling when no logs are available for the selected filters.
  • Ensured the panel is collapsed by default and styled for both light and dark modes.

How to test:

  1. check into current branch
  2. do npm install and npm start to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to BM Dashboard → Tools → Equipment Daily Activity Log
  6. Change the date filter and observe whether logs are returned or the empty-state message is shown.
  7. verify this new feature works in dark mode

Screenshots or videos of changes:

Previous log Previous log expanded

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit fbb9b9a
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/699fd599ee00240008ccfe62
😎 Deploy Preview https://deploy-preview-4655--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

Copy link

@Vikas-8055 Vikas-8055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi sriamsh

Tested this PR locally with the backend Development branch. The "Previous Logs" collapsible panel renders correctly under the Daily Equipment Log table, shows appropriate empty state when no logs exist, and auto-updates based on selected date and project filters. Panel styling and collapse behavior work as expected.
Minor issue: Clicking Submit shows "Failed to update equipment logs" error

Screenshot 2026-01-17 at 12 08 13 AM Screenshot 2026-01-17 at 12 07 59 AM

@Sriamshreddy000
Copy link
Contributor Author

hi sriamsh

Tested this PR locally with the backend Development branch. The "Previous Logs" collapsible panel renders correctly under the Daily Equipment Log table, shows appropriate empty state when no logs exist, and auto-updates based on selected date and project filters. Panel styling and collapse behavior work as expected. Minor issue: Clicking Submit shows "Failed to update equipment logs" error

Hi Vikas,
The submit error appears to be part of the existing Daily Equipment Log submission flow and isn’t related to the “Previous Logs” preview panel added in this PR. This PR only introduces a read-only preview of historical logs and does not modify submit logic or backend update behavior.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Feb 8, 2026
sayali-2308
sayali-2308 previously approved these changes Feb 9, 2026
Copy link
Contributor

@sayali-2308 sayali-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image
  • Checked out branch: sriamsh_previous_logs_panel_daily_equipment
  • Backend: Running on development branch
  • Tested on: Windows, Chrome browser
  • Both servers running locally (Backend: 4500, Frontend: 5173)

Note: Pre-existing CSS issues observed in Project dropdown (light background instead of dark) - not related to this PR's Previous Logs panel feature

Previous Logs preview panel successfully implemented:

  1. Collapsible panel appears below equipment table
  2. Panel collapsed by default to avoid clutter
  3. Displays columns: Equipment, Type, Time
  4. Shows empty state message when no logs available
  5. Auto-updates when date or project filter changes
  6. Styled correctly for both light and dark modes
  7. Helps users see previous log entries for selected date and project

Feature works as described and improves workflow by showing equipment log history, preventing duplicate entries and reducing need to navigate to other pages. All requirements met.

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

I have reviewed your PR locally and though i am able to collapse and preview the panel, i am unable to see any logs. The document does not indicate that this was supposed to be only a frontend PR. Could you confirm on this.
Image
Image
Image
Image
Image
Image

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

I'm not sure if there is a specific date to check, I'm not getting anything.

Image Image

@Sriamshreddy000
Copy link
Contributor Author

Hi Sriamsh,

I have reviewed your PR locally and though i am able to collapse and preview the panel, i am unable to see any logs. The document does not indicate that this was supposed to be only a frontend PR. Could you confirm on this.

Hi Sriamsh,

I'm not sure if there is a specific date to check, I'm not getting anything.

Hi, I found that there was a date mismatch in the code which was preventing logs from displaying correctly. I’ve fixed that and made the necessary updates to ensure the Previous Logs panel now shows the correct entries. It should now behave as expected

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

Well done with the fixes. Dark mode needs some work as it makes the page unusual.

Image Image

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

I have reviewed your PR locally and the logs are visible in both the modes and work as per requirement. However as mentioned in the PR: #4701 (review) same issue is occurring here. Please fix before merge.

Screenshot 2026-02-22 at 12 41 36 AM Screenshot 2026-02-22 at 12 41 44 AM Screenshot 2026-02-22 at 12 41 54 AM Screenshot 2026-02-22 at 12 42 09 AM Screenshot 2026-02-22 at 12 42 20 AM

@Sriamshreddy000 Sriamshreddy000 force-pushed the sriamsh_previous_logs_panel_daily_equipment branch from fda4393 to fbb9b9a Compare February 26, 2026 05:09
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants