Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/components/PRGradingScreen/PRGradingScreen.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { useSelector } from 'react-redux';
import { v4 as uuidv4 } from 'uuid';
import styles from './PRGradingScreen.module.css';

const normalizePrNumbers = prNumbers => (prNumbers || '').replace(/\s+/g, '');

const PRGradingScreen = ({ teamData, reviewers }) => {
const darkMode = useSelector(state => state.theme.darkMode);

Expand Down Expand Up @@ -55,6 +57,17 @@ const PRGradingScreen = ({ teamData, reviewers }) => {
return;
}

const reviewer = reviewerData.find(r => r.id === reviewerId);
const existingPRs = reviewer?.gradedPrs ?? [];
const normalizedNew = normalizePrNumbers(inputValue.trim());
const isDuplicate = existingPRs.some(
pr => pr?.prNumbers && normalizePrNumbers(pr.prNumbers) === normalizedNew,
);
if (isDuplicate) {
setInputError(`PR number "${inputValue.trim()}" already exists for this reviewer`);
return;
}

const newPREntry = {
id: uuidv4(),
prNumbers: inputValue.trim(),
Expand Down Expand Up @@ -232,11 +245,26 @@ const PRGradingScreen = ({ teamData, reviewers }) => {
<input
type="text"
value={inputValue}
onChange={e => setInputValue(e.target.value)}
className={styles['pr-grading-screen-pr-number-input']}
onChange={e => {
setInputValue(e.target.value);
if (inputError) setInputError('');
}}
className={`${styles['pr-grading-screen-pr-number-input']} ${
inputError ? styles['pr-grading-screen-input-error'] : ''
} ${darkMode ? styles['dark-mode'] : ''}`}
placeholder="1070 or 1070 + 1256"
/>

{inputError && (
<p
className={`${styles['pr-grading-screen-error-message']} ${
darkMode ? styles['dark-mode'] : ''
}`}
>
{inputError}
</p>
)}

<Button
variant="primary"
size="sm"
Expand Down
Loading
Loading