fix(klc): avoid empty keys #196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid "Too many OEM" because of empty keys. Now we exit if such a key is detected
Collaborator
fabi1cazenave
left a comment
fabi1cazenave
left a comment
There was a problem hiding this comment.
Looks like a working fix, but this is an opportunity to improve the AHK-related codebase.
kalamine/generators/klc.py
Outdated
| elif base == " ": | ||
| return "SPACE" | ||
| elif base == "-1" and shifted == "-1": | ||
| raise Exception("Empty key are not allowed, please complete the description") |
Collaborator
There was a problem hiding this comment.
Suggested change
| raise Exception("Empty key are not allowed, please complete the description") | |
| raise Exception("Empty keys are not allowed, please complete the description") |
Collaborator
There was a problem hiding this comment.
This section confusing. Where do these "-1" come from? This doesn’t seem sane to me. :-)
The exception message could be more self-explanatory. What should be completed?
And while we’re at it, the "too many OEM keys" message could be a bit better as well.
Collaborator
Author
There was a problem hiding this comment.
I don’t know where the -1 comes from, isn’t it filled by the toml parser?
"Too many OEM" is not very clear indeed, do you have a better idea? I don’t have any ^^'
Co-authored-by: Fabien Cazenave <fabi1cazenave@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid "Too many OEM" because of empty keys. Now we exit if such a key is detected