fix(notification): avoid falling back to saved post metadata for notifications options#402
Merged
sherwinski merged 1 commit intomainfrom Dec 30, 2025
Merged
Conversation
…fications options Only check the POST's `os_update` property when deciding to send a notification. This prevents sending unexpected notifications by tying the logic strictly to the active post's request.
fadi-george
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the schedule notification function to only check the POST's
os_updateproperty when deciding to send a notification. This is to prevent sending unexpected notifications by tying the logic strictly to the active post's request.This change is