Open
Conversation
SeungChoi
force-pushed
the
dev
branch
4 times, most recently
from
117b0b7 to
330a9cf
Compare
SeungChoi
force-pushed
the
dev
branch
2 times, most recently
from
0eab437 to
ba8ec8c
Compare
SeungChoi
force-pushed
the
dev
branch
3 times, most recently
from
65858a1 to
7a3fd2e
Compare
SeungChoi
force-pushed
the
dev
branch
11 times, most recently
from
ba757ac to
faf3311
Compare
SeungChoi
force-pushed
the
dev
branch
3 times, most recently
from
73a7f4e to
ce8b224
Compare
SeungChoi
force-pushed
the
dev
branch
3 times, most recently
from
aad9b00 to
19b2f4b
Compare
SeungChoi
force-pushed
the
dev
branch
3 times, most recently
from
58715ab to
03e4c4c
Compare
SeungChoi
force-pushed
the
dev
branch
2 times, most recently
from
6e7affb to
4198dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looking for feedback on these proposed changes for adding SOCKS support.
What other work needs to be done to complete
Test cases, etc.
Ideally a SOCKS server on the jenkins build server would be ideal. I used jsocks to test this.