Skip to content

remove dependency to io.netty:netty-all for using StringUtil #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SC-MPetzold wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove dependency to io.netty:netty-all for using StringUtil #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-all</artifactId>
<version>4.1.74.Final</version>
</dependency>

<!-- Test dependencies -->
<dependency>
Expand Down
4 changes: 2 additions & 2 deletions sdk/src/main/java/com/silanis/esl/sdk/service/apiclient/AccountApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import com.silanis.esl.sdk.internal.RestClient;
import com.silanis.esl.sdk.internal.Serialization;
import com.silanis.esl.sdk.internal.UrlTemplate;
import io.netty.util.internal.StringUtil;
import org.apache.commons.lang3.StringUtils;

import javax.xml.ws.Response;
import java.util.Collections;
Expand Down Expand Up @@ -410,7 +410,7 @@ public List<String> getAccountRoleUsers(String accountRoleId) {
}

public List<UserAccountRole> getAssignedAccountRoles(String userId, String accountId) {
if (!StringUtil.isNullOrEmpty(accountId)){
if (!StringUtils.isEmpty(accountId)){
template.addParam("accountId", accountId);
}
String path = template.urlFor(UrlTemplate.ACCOUNT_SENDERS_ROLES_PATH)
Expand Down