fix(#4528): pass timeoutMs to detectCcVersion in discoverCcAgents#4547
Merged
Conversation
- Add optional timeoutMs parameter to detectCcVersion - Pass options.timeoutMs through to detectCcVersion in discoverCcAgents - Add overload to isCcAgentsJsonSupported to accept pre-detected version string - Use isCcAgentsJsonSupported in discoverCcAgents to avoid double-parsing semver Closes #4528
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4528
Summary
The
discoverCcAgentsfunction was not passing itsoptions.timeoutMsto thedetectCcVersioncall, causing version detection to always use the hardcoded 5000ms default instead of the caller-configured timeout.Changes
timeoutMsparameter todetectCcVersionoptions.timeoutMsthrough todetectCcVersionindiscoverCcAgentsisCcAgentsJsonSupportedto accept pre-detected version stringisCcAgentsJsonSupportedindiscoverCcAgentsto avoid double-parsing semverVerification