Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/__tests__/fix-3263-runner-abstraction.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,38 @@ describe('Issue #3263 — Runner abstraction layer', () => {
});
});
});

it('unregisters a runner and updates default', () => {
const registry = new InMemoryRunnerRegistry();
const first = new MockRunner('first');
const second = new MockRunner('second');

registry.register(first);
registry.register(second);
expect(registry.getDefault()).toBe(first);

registry.unregister('first');
expect(registry.get('first')).toBeUndefined();
expect(registry.listNames()).toEqual(['second']);
expect(registry.getDefault()).toBe(second);
});

it('unregisters the last runner and getDefault throws', () => {
const registry = new InMemoryRunnerRegistry();
const runner = new MockRunner('only');

registry.register(runner);
registry.unregister('only');
expect(registry.get('only')).toBeUndefined();
expect(registry.listNames()).toEqual([]);
expect(() => registry.getDefault()).toThrow('No runners registered');
});

it('unregister of unknown runner is a no-op', () => {
const registry = new InMemoryRunnerRegistry();
registry.register(new MockRunner('existing'));

registry.unregister('nonexistent');
expect(registry.listNames()).toEqual(['existing']);
expect(registry.getDefault().name).toBe('existing');
});
8 changes: 8 additions & 0 deletions src/runners/registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,12 @@ export class InMemoryRunnerRegistry implements RunnerRegistry {
}
return this.defaultRunner;
}

unregister(name: string): void {
this.runners.delete(name);
// If we removed the default, pick a new one
if (this.defaultRunner?.name === name) {
this.defaultRunner = this.runners.values().next().value;
}
}
}
7 changes: 7 additions & 0 deletions src/runners/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,11 @@ export interface RunnerRegistry {

/** Get the default runner. */
getDefault(): AgentRunner;

/**
* Unregister a runner by name.
*
* @param name - Runner name to remove.
*/
unregister(name: string): void;
}
Loading