fix(ci): remove invalid members permission from PR gate - #84
Merged
Conversation
GitHub Actions rejects permissions.members at parse time, so every push recorded a failed empty pr-gate run and the real pull_request_target gate never started. Co-authored-by: Cursor <cursoragent@cursor.com>
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe ChangesContributor check permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions.membersfrom.github/workflows/pr-gate.yml.Unexpected value 'members'), which produced empty failed runs on every push (e.g. run 30263109321 on PR chore: cloud agent environment install script #83) and prevented the realpull_request_targetcontributor gate from starting.OnlineChefGroep/.githubbranchfix/pr-gate-remove-invalid-members.Test plan
.github/workflows/pr-gate.ymlrun with annotationUnexpected value 'members'.PR Gate/check-contributorstarts normally.Made with Cursor
Greptile Summary
This PR restores the PR Gate workflow’s validity.
permissions.membersentry.contents,issues, andpull-requestspermissions.Confidence Score: 5/5
The PR appears safe to merge, with no actionable defects identified.
The removed permission key is unsupported and could not grant authorization; deleting it allows the workflow to parse while retaining all valid permissions.
Files Needing Attention: No files require additional attention.
What T-Rex did
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): remove invalid members permissi..." | Re-trigger Greptile