Skip to content

fix(ci): remove invalid members permission from PR gate - #84

Merged
OnlineChef merged 1 commit into
mainfrom
fix/pr-gate-remove-invalid-members
Jul 27, 2026
Merged

fix(ci): remove invalid members permission from PR gate#84
OnlineChef merged 1 commit into
mainfrom
fix/pr-gate-remove-invalid-members

Conversation

@OnlineChef

@OnlineChef OnlineChef commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes invalid permissions.members from .github/workflows/pr-gate.yml.
  • GitHub Actions rejects that key at parse time (Unexpected value 'members'), which produced empty failed runs on every push (e.g. run 30263109321 on PR chore: cloud agent environment install script #83) and prevented the real pull_request_target contributor gate from starting.
  • Companion fix for the org reusable: OnlineChefGroep/.github branch fix/pr-gate-remove-invalid-members.

Test plan

  • Confirm the push for this branch does not create a failed empty .github/workflows/pr-gate.yml run with annotation Unexpected value 'members'.
  • After merge, open/reopen a test PR and confirm PR Gate / check-contributor starts normally.
  • Confirm no other workflow permissions were weakened.

Made with Cursor

Greptile Summary

This PR restores the PR Gate workflow’s validity.

  • Removes the unsupported permissions.members entry.
  • Preserves the existing contents, issues, and pull-requests permissions.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified.

The removed permission key is unsupported and could not grant authorization; deleting it allows the workflow to parse while retaining all valid permissions.

Files Needing Attention: No files require additional attention.

T-Rex T-Rex Logs

What T-Rex did

  • Validated the gate permissions change by comparing the before and after logs, confirming that members were previously unsupported and validation failed, and that the after state preserved the permission map with successful validation.
  • Validated the GitHub head-run evidence, confirming HTTP 200 and zero workflow runs for the exact head SHA as recorded in the GitHub API artifact.
  • Verified the post-merge boundary, noting PR 84's merge and the absence of further PRs or runs, which explains why a startup check could not be observed safely.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
.github/workflows/pr-gate.yml Removes an invalid GitHub Actions permission without weakening any effective workflow authorization.

Reviews (1): Last reviewed commit: "fix(ci): remove invalid members permissi..." | Re-trigger Greptile

GitHub Actions rejects permissions.members at parse time, so every push
recorded a failed empty pr-gate run and the real pull_request_target gate
never started.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8438aa06-6318-4b42-9b40-7db2198f1f5a

📥 Commits

Reviewing files that changed from the base of the PR and between 32eb771 and 6cf131c.

📒 Files selected for processing (1)
  • .github/workflows/pr-gate.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/pr-gate.yml

📝 Walkthrough

Walkthrough

The check-contributor job in the pull request workflow no longer requests members: read; its other permissions remain unchanged.

Changes

Contributor check permissions

Layer / File(s) Summary
Workflow permission update
.github/workflows/pr-gate.yml
Removes members: read from the check-contributor job while retaining contents: read, issues: write, and pull-requests: write.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing an invalid workflow permission from the PR gate.
Description check ✅ Passed The description directly matches the workflow permission fix and its impact on GitHub Actions parsing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr-gate-remove-invalid-members

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@OnlineChef
OnlineChef merged commit 7ab2f60 into main Jul 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant