redesign(gui): adopt ChefGroep design language (warm palette, blue accent, shadcn + skins) - #30
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe dashboard adopts a tokenized design language with new typography, colors, skins, controls, component styling, motion, modal transitions, and self-hosted fonts. Skin selection is initialized from the URL or local storage, and page content is wrapped for reveal animation. ChangesDashboard design language
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Target branch corrected This pull request now targets The |
|
Retargeted from |
…cent, Archivo/JetBrains Mono, shadcn buttons, ripple, strak skin) Co-authored-by: OnlineChef <OnlineChef@users.noreply.github.com>
…ful dark basalt Co-authored-by: OnlineChef <OnlineChef@users.noreply.github.com>
…der, tracking) + motion (page reveal, press-physics, matte modal) + gui/DESIGN.md taste guide Co-authored-by: OnlineChef <OnlineChef@users.noreply.github.com>
…der-overview cards to design tokens (caps labels, tabular counts) Co-authored-by: OnlineChef <OnlineChef@users.noreply.github.com>
…ar, neutral nav-active (accent reserved), caps section headers, range/kbd primitives, taste-rules in DESIGN.md Co-authored-by: OnlineChef <OnlineChef@users.noreply.github.com>
Co-authored-by: navarrocorbi-prog <navarrocorbi-prog@users.noreply.github.com>
5fac35c to
59f4fd5
Compare
|
|
||
| <main className="main" inert={navOpen}> | ||
| <div className={`main-inner${page === "combos" ? " main-inner--combos" : ""}`}> | ||
| <div className="page-reveal" key={page}> |
There was a problem hiding this comment.
Combos workspace loses its height constraint
The reveal wrapper becomes the direct child of .main-inner--combos, so .combos-workspace-shell no longer matches the direct-child sizing rule in styles.css. With populated Combos data, the wrapper and workspace expand to their content height while the fixed-height main container clips overflow. The intended detail-panel scrollbar has no overflow to scroll, leaving content below the viewport inaccessible. Keep the Combos shell as the direct child, or give the wrapper the same constrained flex sizing behavior.
Artifacts
- Playwright renders the prior direct-child workspace, selects a combo, and scrolls the constrained detail panel; the workspace remains viewport-height and usable.
Poster frame of the prior direct-child Combos workspace
- The pre-change workspace fills the 900px main area and keeps scrolling inside its detail region.
- Playwright renders the candidate wrapper path and shows the workspace expanding beyond the clipped main viewport instead of maintaining the intended inner scrolling.
Poster frame of the candidate Combos workspace after page-reveal wrapper insertion
- The candidate view demonstrates the affected wrapper path after its reveal animation has settled.
- This executable fixture script serves the populated Combos route, compares direct-child and wrapper structures, performs a scroll attempt, and records layout metrics.
- The actual command output records exit code 0 and shows baseline 900px sizing versus candidate 2176px wrapper and workspace sizing, confirming the clipping and scrolling failure.
- The generated metrics provide the exact computed boxes, overflow values, and scroll dimensions for the matched before and candidate runs.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: gui/src/App.tsx
Line: 291
Comment:
**Combos workspace loses its height constraint**
The reveal wrapper becomes the direct child of `.main-inner--combos`, so `.combos-workspace-shell` no longer matches the direct-child sizing rule in `styles.css`. With populated Combos data, the wrapper and workspace expand to their content height while the fixed-height main container clips overflow. The intended detail-panel scrollbar has no overflow to scroll, leaving content below the viewport inaccessible. Keep the Combos shell as the direct child, or give the wrapper the same constrained flex sizing behavior.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Re-skins the opencodex
gui/dashboard to theOnlineChefGroep/design-systemv2 "Devin-richting" language, perPLAN.md, and adds a typography + motion refinement pass plus a living taste/design guide. Presentation-only — no proxy/runtime/API changes.Rebased onto current
dev(was branched frommainand conflicted). Diff is now 7 GUI files only.Changes
gui/src/styles.css:root(light + dark) → warm off-white surfaces, one blue accent split from the monochrome primary action, reserved green/amber/red, tighter radii, design easing. Removed the ambient gradient wash, glass/backdrop-blur and heavy shadows for a flat matte surface (modals are now opaque cards, not frosted glass).--text-micro…--text-display), calmer leading,--tracking-tighton headings, uppercase micro.capsstat labels, tabular figures (.num) on all numeric data so columns align,.prosemeasure, better rendering (optimizeLegibility, grayscale smoothing). Provider-overview cards realigned to the same tokens for cross-page consistency.@fontsource. Dropped unused@fontsource/ibm-plex-mono..btn(rounded-rect +scale(0.97)press), sans pill.badge, blue input focus ring, blue toggles, blue active-nav/selected-tab.data-style="strak"(cooler, sharper) alongside default warmdevin, applied at boot from?style=or a saved choice.gui/DESIGN.md— the taste + design guide with a token reference and a concrete "how to extend" section.Verification
bun run typecheck— greenbun --bun run lint:gui— greenbun run privacy:scan— greendev(endefault; no forced Dutch —devhas nonllocale, and forcing it broke number-format tests on the earliermain-based branch)Notes
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Summary by CodeRabbit
New Features
Documentation
Greptile Summary
This change refreshes the GUI with ChefGroep skins, typography, component styling, bundled fonts, reduced-motion-aware animation, a design guide, and page-reveal transitions.
The Combos page was rendered with populated data at a 1440×900 viewport. The new page-reveal wrapper causes the workspace to grow to its content height while the main area remains a clipped viewport-height container. The detail panel no longer receives the intended internal scrollbar, leaving lower combo details inaccessible.
Do not merge until the Combos workspace height constraint is restored.
Confidence Score: 3/5
What T-Rex did
Comments Outside Diff (1)
General comment
.page-reveal,.combos-workspace-shell,.combos-workspace-root, and.combos-workspace-detail2176px high. The intended scrollable detail panel therefore hasscrollHeight === clientHeight === 2176, while.main-inner--combosremains 900px tall withoverflow: hidden; content below the visible area is inaccessible through the intended panel scroll path.gui/src/styles.css:417only applies when.combos-workspace-shellis a direct child of.main-inner--combos. The wrapper inserted atgui/src/App.tsx:291becomes the direct child but has no equivalentflex: 1,min-height: 0,height: 100%, or flex-column sizing, so its content-driven height propagates into the workspace..main-inner--combos > .page-revealand make it a flex column withflex: 1 1 auto,min-height: 0, andheight: 100%(then ensure its shell child fills it).Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "chore(gui): drop unused ibm-plex-mono af..." | Re-trigger Greptile