fix(gui): complete English i18n, keep only en/nl - #34
Conversation
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
✅ Target branch corrected This pull request now targets The |
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GUI now supports English and Dutch only, adds English strings for new workflows and dashboards, and removes obsolete locale mappings and dictionaries. CI retries Windows tests after detected Bun crashes. Issue triage assembles prompts through a grouped heredoc command. ChangesGUI localization updates
Windows test retry
Issue triage prompt generation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adopt origin/dev's canonical en.ts (1611 keys) so main's GUI typechecks again, drop de/ja/ko/ru/zh, and keep Dutch as the Joep-facing override.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
8921fac to
5312254
Compare
…onary Dropping de/ja/ko/ru/zh left seven gui/tests suites enumerating dictionary modules that no longer exist, so they failed with ENOENT. English is now the only full dictionary; nl.ts spreads en and overrides a subset, so it cannot be missing keys. The key-set equality test is replaced with a check that Dutch overrides never reference a key absent from en. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Bun 1.3.14 on windows-latest intermittently aborts the suite with "Internal assertion failure" while churning storage-policy Workers. Settle terminate on win32 and retry the Test step once only when the log shows a Bun runtime crash. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 88: Update the workflow step containing the matrix.os check to pass
matrix.os through the step’s env block, then compare the quoted environment
variable in the Bash condition instead of embedding the template expression in
executable shell code. Preserve the existing non-Windows behavior and obtain
explicit security review for this .github workflow change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4ab54aed-3002-4827-b42b-1134fda6e094
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/issue-triage.yml
…pansion Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Summary
gui/src/i18n/en.tsand keep onlyen/nllocales (dropsde/ja/ko/ru/zh— 8.3k regels minder).nl-locale opdev(die was bij een eerdere merge verdwenen) met Nederlands als Joep-facing default.shared.ts,formatUptime.ts,QuotaBars.tsx; language switcher toont alleen Nederlands / English.Retarget note
Oorspronkelijk per ongeluk tegen
maingeopend. Branch is opnieuw gebaseerd opdev(conflictoplossing: dev's nieuwere lockfile behouden, locale-deletes doorgezet). De docs-alinea over de Bun CLI zat al opdeven is weggevallen als no-op.Test plan (gedraaid op deze branch)
cd gui && bunx tsc -b— 0 errorscd gui && bunx --bun eslint .— 0 errorsbun run test— 6213 pass / 0 failSummary by CodeRabbit