Skip to content

fix(gui): complete English i18n, keep only en/nl - #34

Merged
OnlineChef merged 7 commits into
devfrom
fix/gui-en-i18n-keys
Aug 1, 2026
Merged

fix(gui): complete English i18n, keep only en/nl#34
OnlineChef merged 7 commits into
devfrom
fix/gui-en-i18n-keys

Conversation

@OnlineChef

@OnlineChef OnlineChef commented Jul 31, 2026

Copy link
Copy Markdown

Summary

  • Adopt canonical gui/src/i18n/en.ts and keep only en/nl locales (drops de/ja/ko/ru/zh — 8.3k regels minder).
  • Herstelt de nl-locale op dev (die was bij een eerdere merge verdwenen) met Nederlands als Joep-facing default.
  • Trim locale switches in shared.ts, formatUptime.ts, QuotaBars.tsx; language switcher toont alleen Nederlands / English.

Retarget note

Oorspronkelijk per ongeluk tegen main geopend. Branch is opnieuw gebaseerd op dev (conflictoplossing: dev's nieuwere lockfile behouden, locale-deletes doorgezet). De docs-alinea over de Bun CLI zat al op dev en is weggevallen als no-op.

Test plan (gedraaid op deze branch)

  • cd gui && bunx tsc -b — 0 errors
  • cd gui && bunx --bun eslint . — 0 errors
  • bun run test — 6213 pass / 0 fail
  • Spot-check: language switcher biedt alleen Nederlands / English
  • Verkeer / Systeem / Modellen renderen onder beide locales

Summary by CodeRabbit

  • New Features
    • Added English labels and messages for startup repair, diagnostics, storage management, account pools, API workspace views, and fleet monitoring.
  • Changes
    • Reduced available interface languages to English and Dutch; Dutch is now the default when no supported language is detected.
    • Removed uptime translations for several previously supported languages.
  • Bug Fixes
    • Improved Windows test reliability by retrying only after specific runtime crashes.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

Target branch corrected

This pull request now targets dev.

The [WRONG BRANCH] title prefix has been removed. The pull request has been marked ready for review again.

@github-actions github-actions Bot changed the title fix(gui): complete English i18n, keep only en/nl [WRONG BRANCH] fix(gui): complete English i18n, keep only en/nl Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@OnlineChef, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 948be81e-652d-4cad-ae1c-74280b6fed73

📥 Commits

Reviewing files that changed from the base of the PR and between 51ee42e and c03bf02.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
📝 Walkthrough

Walkthrough

The GUI now supports English and Dutch only, adds English strings for new workflows and dashboards, and removes obsolete locale mappings and dictionaries. CI retries Windows tests after detected Bun crashes. Issue triage assembles prompts through a grouped heredoc command.

Changes

GUI localization updates

Layer / File(s) Summary
Reduce locale support and locale mappings
gui/src/i18n/shared.ts, gui/src/i18n/de.ts, gui/src/i18n/ko.ts, gui/src/i18n/zh.ts, gui/src/i18n/ru.ts, gui/src/i18n/ja.ts, gui/src/formatUptime.ts, gui/src/components/QuotaBars.tsx
Locale registration now contains English and Dutch. The removed locale modules and locale-specific quota and uptime mappings are no longer used.
Add startup and diagnostics translations
gui/src/i18n/en.ts
English strings cover startup repair, memory drain-and-restart states, delegation guidance, model availability, and subagent workspace controls.
Add usage and storage translations
gui/src/i18n/en.ts
English strings cover proxy and provider usage, request-quality metrics, quarantine and restoration, cleanup, and automatic cleanup policies.
Add provider, workspace, and fleet translations
gui/src/i18n/en.ts
English strings cover API-key transport, account pooling and pausing, API-key workspaces, Claude settings, fleet navigation, and live traffic states.

Windows test retry

Layer / File(s) Summary
Handle Windows Bun crashes
.github/workflows/ci.yml
Windows tests capture output and retry once when the failure contains Bun has crashed. Other failures retain their original exit status.

Issue triage prompt generation

Layer / File(s) Summary
Assemble the triage prompt
.github/workflows/issue-triage.yml
The workflow writes the prompt template and current and existing issue JSON through one grouped heredoc command.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested reviewers: lidge-jun, wibias

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main GUI localization change: completing English i18n and retaining only English and Dutch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gui-en-i18n-keys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

GroepChef and others added 4 commits August 1, 2026 14:51
Adopt origin/dev's canonical en.ts (1611 keys) so main's GUI typechecks
again, drop de/ja/ko/ru/zh, and keep Dutch as the Joep-facing override.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@OnlineChef
OnlineChef changed the base branch from main to dev August 1, 2026 13:03
@github-actions github-actions Bot changed the title [WRONG BRANCH] fix(gui): complete English i18n, keep only en/nl fix(gui): complete English i18n, keep only en/nl Aug 1, 2026
@OnlineChef
OnlineChef force-pushed the fix/gui-en-i18n-keys branch from 8921fac to 5312254 Compare August 1, 2026 13:04
@github-actions github-actions Bot added the bug Something isn't working label Aug 1, 2026
OnlineChef and others added 2 commits August 1, 2026 13:14
…onary

Dropping de/ja/ko/ru/zh left seven gui/tests suites enumerating dictionary
modules that no longer exist, so they failed with ENOENT. English is now the
only full dictionary; nl.ts spreads en and overrides a subset, so it cannot be
missing keys. The key-set equality test is replaced with a check that Dutch
overrides never reference a key absent from en.

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Bun 1.3.14 on windows-latest intermittently aborts the suite with
"Internal assertion failure" while churning storage-policy Workers.
Settle terminate on win32 and retry the Test step once only when the
log shows a Bun runtime crash.

Co-authored-by: Cursor <cursoragent@cursor.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Line 88: Update the workflow step containing the matrix.os check to pass
matrix.os through the step’s env block, then compare the quoted environment
variable in the Bash condition instead of embedding the template expression in
executable shell code. Preserve the existing non-Windows behavior and obtain
explicit security review for this .github workflow change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4ab54aed-3002-4827-b42b-1134fda6e094

📥 Commits

Reviewing files that changed from the base of the PR and between dfc8543 and 51ee42e.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/issue-triage.yml

Comment thread .github/workflows/ci.yml Outdated
…pansion

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@OnlineChef
OnlineChef merged commit 272a431 into dev Aug 1, 2026
11 checks passed
@OnlineChef
OnlineChef deleted the fix/gui-en-i18n-keys branch August 1, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant