Couple of improvements for faster tests#1288
Open
jfckm wants to merge 2 commits intoOpen-CAS:masterfrom
Open
Conversation
amd-pdebski
reviewed
Jul 25, 2022
kajakoltan
previously approved these changes
Jul 25, 2022
mmichal10
previously approved these changes
Jul 29, 2022
jfckm
force-pushed
the
faster-tests
branch
3 times, most recently
from
ccc3af0 to
5f230ed
Compare
amd-pdebski
previously approved these changes
Aug 19, 2022
kmajzero
reviewed
Aug 22, 2022
Contributor
kmajzero
left a comment
kmajzero
left a comment
There was a problem hiding this comment.
What if a particular test would need custom setup/teardown? Is this possible (or even needed)?
Contributor
Author
Right now I believe it's handled by doing prepare/teardown inline in test or separating it out to per-module functions. You could also use fixtures, but (sadly) they don't get much use in our TF/tests. |
kmajzero
previously approved these changes
Aug 22, 2022
arutk
reviewed
Aug 22, 2022
jfckm
force-pushed
the
faster-tests
branch
2 times, most recently
from
a07347f to
0e80c34
Compare
Contributor
Author
|
@CAS-Linux-Jenkins retest this please |
added 2 commits
September 13, 2022 10:25
Signed-off-by: Jan Musial <jan.musial@intel.com>
Signed-off-by: Jan Musial <jan.musial@intel.com>
Contributor
|
needs serious analysis, preferably by the author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs changes in test-framework. Also, fails sporadically while removing partitions - still needs some debugging
This change is