Add test for installing OpenCAS from RPM package #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Ostrokrzew! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-14 13:52:24 UTC |
Ostrokrzew
changed the title
robertbaldyga
requested changes
Apr 27, 2020
Ostrokrzew
force-pushed
the
test_rpm
branch
2 times, most recently
from
547e1a2 to
61f062b
Compare
rafalste
reviewed
May 22, 2020
rafalste
reviewed
May 24, 2020
mmichal10
reviewed
May 26, 2020
rafalste
reviewed
May 26, 2020
mmichal10
reviewed
May 27, 2020
Ostrokrzew
force-pushed
the
test_rpm
branch
4 times, most recently
from
db16c41 to
2c94637
Compare
mmichal10
reviewed
May 28, 2020
katlapinka
requested changes
May 28, 2020
Deixx
requested changes
May 28, 2020
Contributor
|
retest this please |
mmichal10
reviewed
Jun 9, 2020
Ostrokrzew
force-pushed
the
test_rpm
branch
2 times, most recently
from
b1d5521 to
cb7b117
Compare
Ostrokrzew
force-pushed
the
test_rpm
branch
2 times, most recently
from
4440dd5 to
4d6e523
Compare
mmichal10
reviewed
Jun 30, 2020
Contributor
|
retest this please |
Ostrokrzew
force-pushed
the
test_rpm
branch
4 times, most recently
from
c6b3086 to
3b7448a
Compare
rafalste
reviewed
Aug 7, 2020
Ostrokrzew
force-pushed
the
test_rpm
branch
4 times, most recently
from
8ed9d93 to
c984623
Compare
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Remove unused imports from `installer` module. Create class from `installer` with static methods. Wrap `_rsync_opencas`. Add timeout to `_rsync_opencas`. Extract checking if `casadm` works. Remove checking if CAS is installed from `uninstall_opencas` method. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
`RpmInstaller` overwrites few methods to handle RPM functionality. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Add parsing new CLI flag `--rpm-install` to inform framework that user want to install OpenCAS not from sources (default), but from RPM packages. Additionaly user can pass in config file own path to ready-to-install RPM packages. Extend `Opencas` class with field `rpm_dir`. Use new pytest mark in prepare stage. Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Signed-off-by: Slawomir Jankowski <slawomir.jankowski@intel.com>
Ostrokrzew
force-pushed
the
test_rpm
branch
from
010de0b to
728316e
Compare
Deixx
requested changes
Oct 20, 2020
Comment on lines
+99
to
+105
| TestRun.LOGGER.info("Check if 'casadm' is properly installed.") | ||
| output = TestRun.executor.run("casadm -V") | ||
| if output.exit_code != 0: | ||
| return False | ||
| else: | ||
| TestRun.LOGGER.info(output.stdout) | ||
| return True |
Contributor
There was a problem hiding this comment.
'which casadm' does the job, and we don't need output from casadm here
| installer.reinstall_opencas() | ||
| elif not installer.check_if_installed(): | ||
| installer.rsync_opencas_sources() | ||
| elif not opencas_installed and not uninstall_cas: |
Contributor
There was a problem hiding this comment.
uninstall_cas is always False here
| if opencas_installed: | ||
| RpmInstaller.uninstall_opencas() | ||
| elif get_force_param(item) and not TestRun.usr.already_updated: | ||
| installer.reinstall_opencas() |
Contributor
There was a problem hiding this comment.
If RPM is installed and we want to reinstall from sources then installer.reinstall_opencas() will try to remove only source-based installation (and fail), and then will try to install from sources although RPM would still be installed.
|
Can one of the admins verify this patch? |
Contributor
|
Remove kedr test and update test for rpm installer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs https://github.com/Open-CAS/test-framework/pull/166