Skip to content

Conversation

@grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Jan 14, 2026

Addressing: #2315

VS Code uses an internal schema resolution engine to determine what hover text to show. When schemas have ambiguous matches (e.g. oneOf, $ref, or combinators), the language server may not choose a single effective path so it doesn’t show specific description/title. Also the language service has known limitations around hover text.

In the specific case of setup node since the change include use of allof instead of oneof. It shouldn't make any change since we have only of ref to be complaint with.

@github-actions
Copy link

Test Results

    3 files     21 suites   13m 59s ⏱️
  438 tests   438 ✅ 0 💤 0 ❌
1 314 runs  1 314 ✅ 0 💤 0 ❌

Results for commit 5485353.

@brondani brondani merged commit c0d1a76 into Open-CMSIS-Pack:main Jan 14, 2026
32 of 33 checks passed
@brondani brondani deleted the outbound/update-schema branch January 14, 2026 13:10
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.37%. Comparing base (bdeed3f) to head (5485353).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...projmgr/test/src/ProjMgrSchemaCheckerUnitTests.cpp 75.00% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2321   +/-   ##
=======================================
  Coverage   66.36%   66.37%           
=======================================
  Files         181      181           
  Lines       36737    36777   +40     
  Branches    22867    22887   +20     
=======================================
+ Hits        24380    24410   +30     
- Misses       7627     7633    +6     
- Partials     4730     4734    +4     
Flag Coverage Δ
projmgr-cov 80.21% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...projmgr/test/src/ProjMgrSchemaCheckerUnitTests.cpp 77.60% <75.00%> (-0.69%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants