Alternative templater review#4
Open
nick-gorman wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| - Generator unique naming — currently `{technology}_{isp_code}_{node_id}`, would become `{technology}_{resource_type}_{node_id}` | ||
| - Translator VRE build limit constraint groups (`_VRE_BUILD_LIMIT_CUSTOM_CONSTRAINT_GROUPS` in `mappings.py`) — filters generators by `isp_resource_type` values; must be updated to match new names | ||
|
|
||
| **Note:** This canonicalization is **optional**. The current ISP codes (`WH`, `WM`, `SAT`, etc.) are concise and unambiguous. Retaining them avoids changes to the translator's constraint configuration and generator naming. The trade-off is readability: `wind_high` is more self-documenting than `WH` for new users of the schema. Either approach is acceptable — the key requirement is consistency between `assets_new_generators.resource_type` and `node_resource_limits.resource_type`. |
Member
There was a problem hiding this comment.
I think at the moment the WH, WM etc codes are also used to map to generator traces - though this can definitely be handled easily so not a drama. I'll keep thinking about this one, I'm pretty pro making things more readable and removing caps feels nice on the eyes too
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative proposal for revising the templater output.
The key difference in this proposal is to use a unified geographical unit, a node, to represent both subregions and rezs.