implemented handshake #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcq888
reviewed
Feb 7, 2026
| const data = await response.json(); | ||
| return data.model_name || 'XRPCode Buddy'; | ||
| } catch { | ||
| return 'XRPCode Buddy'; |
Collaborator
There was a problem hiding this comment.
shouldn't this be XRP Buddy?
Collaborator
Author
There was a problem hiding this comment.
leaving this to be a separate PR since seems like there are issues with the other one
| if (this.handshakeToken) return this.handshakeToken; | ||
|
|
||
| try { | ||
| const response = await fetch(`${this.backendUrl}/handshake`); |
Collaborator
There was a problem hiding this comment.
How does the backend know that the client is XRPWeb? This call does not pass anything to the backend?
Collaborator
Author
There was a problem hiding this comment.
couple of thoughts:
- there is a trusted domains setting that only (easily) allows requests through the localhost
- the handshake creates a key in the backend that then is passed back to the front end. this stops a script from just "curling" our API thousands of times because it requires a state to be stored with the handshake key
- we can't really stop someone from emulating our frontend (since all of the code and schemas are open source). we could do so by storing a DB of users (emails and passwords) and can talk about this in in our next meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.