Skip to content

fix:race condition in db tracking module #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uhurusurfa merged 7 commits into from
Jan 27, 2026
Merged

fix:race condition in db tracking module #498

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
37d24c7
fix:race condition in db tracking module
cunla Jan 27, 2026
35c65f2
fix:race condition in db tracking module
cunla Jan 27, 2026
5bddd1f
wip
cunla Jan 27, 2026
5b05fec
wip
cunla Jan 27, 2026
f9e4a08
wip
cunla Jan 27, 2026
f3bfc2f
wip
cunla Jan 27, 2026
2c4cb55
wip
cunla Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Server/src/main/java/org/openas2/processor/msgtracking/DbTrackingModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,13 @@ protected CompositeParameters createParser() {
return params;
}

protected void persist(Message msg, Map<String, String> map) {
protected synchronized void persist(Message msg, Map<String, String> map) {
String msgIdField = FIELDS.MSG_ID;
String msgIdValue = map.get(msgIdField);
try (Connection conn = dbHandler.getConnection()) {
Statement s = conn.createStatement();
String msgIdField = FIELDS.MSG_ID;
ResultSet rs = s.executeQuery(
"SELECT * FROM " + tableName + " WHERE " + msgIdField + " = '" + map.get(msgIdField) + "'");
"SELECT * FROM " + tableName + " WHERE " + msgIdField + " = '" + msgIdValue + "'");
ResultSetMetaData meta = rs.getMetaData();
boolean isUpdate = rs.next(); // Record already exists so update
if (logger.isTraceEnabled()) {
Expand Down Expand Up @@ -178,7 +179,6 @@ protected void persist(Message msg, Map<String, String> map) {
+ " ::: Data map: " + map);
logger.error(msg.getLogMsg(), e);
}

}

public ArrayList<HashMap<String, String>> listMessages() {
Expand Down
Loading