Open
Conversation
added 2 commits
April 4, 2023 13:12
maw501
suggested changes
Apr 6, 2023
There was a problem hiding this comment.
Do you think it might be easier to not modify main.py but instead create a new script which is the same as your current one? I'm just thinking that if we try to sync the fork we're going to have to resolve all the conflicts each time. So:
main.py: the original filesomething.py: the new one you want to create (i.e. the same asmain.pycurrently on this PR).
You'll also need to update the other PR here to reflect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes to eval main() to allow wandb tracking of evaluation metrics