Open
Conversation
Author
|
Set line 84 to n_params instead of hardcoding, and averaging using wandb grouping for figure 4, the ticket should be complete now. |
Collaborator
|
Good job! Just a few points:
|
Author
|
Good catch on the save_path for the trials, I will add the trial id to separate every output and also merge with the checkpoint on the master branch. |
…set the save_path in config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I combined experiments 3 and 4 for issue #19.
Only 2 things remain unsolved. First, on line 84 the n_params is hardcoded to 3, should this be passed like in Figure 3?
rl-oed/examples/Figure_4_RT3D_chemostat/train_RT3D.py
Line 84 in 50cd5a9
Second, experiment 4 is not averaged on the experiment side, should we average on the experiment side or use weights and biases?
If these are resolved we can remove Figure_3 and Figure_4.
Changes