Open
Conversation
Vekhir
force-pushed
the
podcast-improvements
branch
2 times, most recently
from
d55459b to
cd265bb
Compare
The new podcast preferences dialog replaces the small checkbox list. It allows direct adjustment of audio recording device, bit rate, and frame rate. For each profile of "Full", "Medium", and "Small", the bit rate, frame rate and video size are reported based on the chosen settings. The dialog is based off the recently added color preferences dialog. Each profile has its own tab. The selected tabs' profile is used for recording. The audio device can be no input, default input, or a specified device. The UI handles the invalid states, so that the user cannot enter invalid combinations.
The upload dialog contains options related to uploading the recorded videos.
Vekhir
force-pushed
the
podcast-improvements
branch
from
cd265bb to
42937b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the podcast preferences are set with a tiny menu on the podcast palette. This PR replaces that menu with a dedicated dialog window which also shows which settings are applied when choosing a specific recording profile and allows to change the bit rate and frame rate from within OpenBoard.
All previous options and settings are retained. The dialog itself is based on the color preferences dialog.
I think the dialog is self-explanatory. The design can probably be improved (though after some time, it doesn't look as horrible anymore), but the key functionalities are all in place and ready-to-go.
This restructuring separates the settings fields from their use, so the podcast controller must load the settings anew before starting the recording. This now includes the FPS, which previously wasn't used at all. The default value has been bumped to 100, leading to real fps of around 40-70.
I should note that I only tested on Arch Linux with the CMake community build and Qt 6. I don't expect any breakage, but if you do experience issues, please let me know.
Also, I didn't touch the translations. Any help with that is appreciated.
This PR is preparation for #1232.
Solves #991 #106