chore: regenerate with fabrica v0.4.9#27
Merged
synackd merged 5 commits intoJul 22, 2026
Conversation
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
synackd
force-pushed
the
26-regenerate-with-fabrica-v049-to-incorporate-featuresfixes
branch
3 times, most recently
from
July 21, 2026 19:43
bf42f85 to
04ff103
Compare
The: go run github.com/openchami/fabrica@<version> invocation does not work because the "generated by" lines in the generated files do not get the fabrica version populated. Therefore, fabrica needs to be built locally using the local build system to properly ingrain the version. Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
synackd
force-pushed
the
26-regenerate-with-fabrica-v049-to-incorporate-featuresfixes
branch
from
July 21, 2026 21:11
bd8b37e to
6c8cea5
Compare
synackd
marked this pull request as ready for review
July 21, 2026 21:20
Contributor
Author
|
This was tested with OpenCHAMI/release#50 using the following config file: ---
# boot-service config file
# boot-service listen port
port: 8081
# Toggles enablement of legacy, BSS-compatible boot API (/boot/v1)
enable_legacy_api: false
# Enable token authentication (requires tokensmith_url)
enable_auth: true
tokensmith_url: 'http://tokensmith:8080'
tokensmith_target_service: 'smd'
# URL to inventory service for syncing node/BMC data
hsm_url: 'http://smd:27779'
hsm_sync_enabled: trueThis worked to boot a VM. |
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Contributor
Author
|
Metrics enabled and tested enabling/disabling with |
davidallendj
approved these changes
Jul 22, 2026
davidallendj
left a comment
davidallendj
left a comment
Contributor
There was a problem hiding this comment.
Can confirm that the /metrics endpoint worked like expected when both enabled and disabled. I'll go ahead and approve.
synackd
deleted the
26-regenerate-with-fabrica-v049-to-incorporate-featuresfixes
branch
July 22, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26
Note
.github/workflows/codegen-check.yamlneeded to be modified to use the proper Fabrica version. That is, the one in go.mod.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
For more info, see Contributing Guidelines.