Conversation
Collaborator
Pull Request Test Coverage Report for Build 12930142736Details
💛 - Coveralls |
rettigl
force-pushed
the
elab_metadata_integration
branch
3 times, most recently
from
81f50ef to
1ed013c
Compare
look for .env file also in system config folder
rettigl
force-pushed
the
elab_metadata_integration
branch
from
9f6fba7 to
38513cb
Compare
fix matplotlib warnings
Shift energy axis
estimate collection time for static exposures
Pynxtools update
There was a problem hiding this comment.
Copilot reviewed 15 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .cspell/custom-dictionary.txt: Language not supported
- docs/specsanalyzer/config.rst: Language not supported
- docs/specsscan/helpers.rst: Language not supported
- src/specsscan/config/NXmpes_arpes_config.json: Language not supported
- tests/data: Language not supported
Comments suppressed due to low confidence (2)
src/specsscan/metadata.py:210
- Consider adding error handling for cases when 'extra_fields' is missing or structured unexpectedly in the loaded JSON to prevent potential runtime errors.
for key, val in metadata_json["extra_fields"].items():
src/specsanalyzer/config.py:260
- [nitpick] Enhance the '_parse_env_file' logic to handle cases such as quoted values or extra whitespace to improve robustness when parsing environment variable files.
def read_env_var(var_name: str) -> str | None:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration of elabftw metadata