Merge pull request #255 from DevanshuNEU/chore/cleanup-dotenv-headers-emojis

chore: consolidate load_dotenv, remove decorative headers, fix emojis (OPE-86, OPE-74)

Author: DevanshuNEU

backend/config/api.py

@@ -5,15 +5,11 @@
 Example: "v1" -> "v2" will change /api/v1/* to /api/v2/*
 """
 
-# =============================================================================
 # API VERSION CONFIGURATION
-# =============================================================================
 
 API_VERSION = "v1"
 
-# =============================================================================
 # DERIVED PREFIXES (auto-calculated from version)
-# =============================================================================
 
 # Current versioned API prefix: /api/v1
 API_PREFIX = f"/api/{API_VERSION}"
@@ -22,9 +18,7 @@
 # Routes here will be deprecated but still functional
 LEGACY_API_PREFIX = "/api"
 
-# =============================================================================
 # DEPRECATION SETTINGS
-# =============================================================================
 
 # When True, legacy routes (/api/*) will include deprecation warning headers
 LEGACY_DEPRECATION_ENABLED = True
@@ -33,9 +27,7 @@
 DEPRECATION_HEADER = "X-API-Deprecated"
 DEPRECATION_MESSAGE = f"This endpoint is deprecated. Please use {API_PREFIX} instead."
 
-# =============================================================================
 # HELPER FUNCTIONS
-# =============================================================================
 
 def get_versioned_prefix() -> str:
     """Get the current versioned API prefix."""

backend/dependencies.py

@@ -3,10 +3,6 @@
 All route modules import from here to avoid circular imports.
 """
 from fastapi import HTTPException, Depends
-from dotenv import load_dotenv
-
-# Load env vars first
-load_dotenv()
 
 from services.indexer_optimized import OptimizedCodeIndexer
 from services.repo_manager import RepositoryManager

backend/main.py

@@ -2,6 +2,10 @@
 CodeIntel Backend API
 FastAPI backend for codebase intelligence
 """
+# Load env vars once, before any service reads them
+from dotenv import load_dotenv
+load_dotenv()
+
 from contextlib import asynccontextmanager
 from fastapi import FastAPI, Request
 from fastapi.middleware.cors import CORSMiddleware
@@ -51,8 +55,7 @@ async def lifespan(app: FastAPI):
 )
 
 
-# ===== MIDDLEWARE =====
-
+# MIDDLEWARE
 class RequestSizeLimitMiddleware(BaseHTTPMiddleware):
     """Limit request body size to prevent abuse."""
     MAX_REQUEST_SIZE = 10 * 1024 * 1024  # 10MB
@@ -81,7 +84,7 @@ async def dispatch(self, request: Request, call_next):
 )
 
 
-# ===== ROUTERS =====
+# ROUTERS
 # All API routes are prefixed with API_PREFIX (e.g., /api/v1)
 # Route files define their sub-path (e.g., /auth, /repos)
 # Final paths: /api/v1/auth, /api/v1/repos, etc.
@@ -104,8 +107,7 @@ async def dispatch(self, request: Request, call_next):
 app.add_api_websocket_route(f"{API_PREFIX}/ws/repos/{{repo_id}}/indexing", websocket_repo_indexing)
 
 
-# ===== ERROR HANDLERS =====
-
+# ERROR HANDLERS
 @app.exception_handler(RequestValidationError)
 async def validation_exception_handler(request: Request, exc: RequestValidationError):
     """Handle validation errors with clear messages."""

backend/middleware/auth.py

@@ -29,9 +29,7 @@ async def demo_search(auth: AuthContext = Depends(public_auth)):
 from fastapi.security.http import HTTPAuthorizationCredentials
 
 
-# ---------------------------------------------------------------------------
 # Auth Context - unified return type for all auth methods
-# ---------------------------------------------------------------------------
 
 @dataclass
 class AuthContext:
@@ -52,17 +50,13 @@ def identifier(self) -> str:
         return self.user_id or self.api_key_name or "anonymous"
 
 
-# ---------------------------------------------------------------------------
 # Bearer token scheme (auto_error=False allows optional auth)
-# ---------------------------------------------------------------------------
 
 _bearer = HTTPBearer(auto_error=False)
 _bearer_required = HTTPBearer(auto_error=True)
 
 
-# ---------------------------------------------------------------------------
 # Core validation functions
-# ---------------------------------------------------------------------------
 
 def _validate_jwt(token: str) -> Optional[AuthContext]:
     """Validate Supabase JWT token"""
@@ -143,9 +137,7 @@ def _authenticate(token: str) -> AuthContext:
     )
 
 
-# ---------------------------------------------------------------------------
 # FastAPI Dependencies - use these in your routes
-# ---------------------------------------------------------------------------
 
 async def require_auth(
     credentials: HTTPAuthorizationCredentials = Depends(_bearer_required)
@@ -177,9 +169,7 @@ async def public_auth(
         return AuthContext(is_public=True)
 
 
-# ---------------------------------------------------------------------------
 # Legacy functions - kept for backwards compatibility
-# ---------------------------------------------------------------------------
 
 async def get_current_user(
     credentials: HTTPAuthorizationCredentials = Depends(_bearer_required)

backend/routes/playground.py

@@ -785,9 +785,7 @@ async def validate_github_repo(request: ValidateRepoRequest, req: Request):
     return result
 
 
-# =============================================================================
 # Anonymous Indexing Endpoint (#125)
-# =============================================================================
 
 @router.post("/index", status_code=202)
 async def start_anonymous_indexing(
@@ -1030,9 +1028,7 @@ async def start_anonymous_indexing(
     return response_data
 
 
-# =============================================================================
 # GET /playground/index/{job_id} - Check indexing job status (#126)
-# =============================================================================
 
 @router.get(
     "/index/{job_id}",

backend/services/cache.py

@@ -7,12 +7,9 @@
 import hashlib
 from typing import Optional, List, Dict
 import os
-from dotenv import load_dotenv
 
 from services.observability import logger, metrics
 
-load_dotenv()
-
 # Configuration
 REDIS_URL = os.getenv("REDIS_URL")  # Railway/Cloud Redis URL
 REDIS_HOST = os.getenv("REDIS_HOST", "localhost")

backend/services/dependency_analyzer.py

@@ -399,8 +399,7 @@ def _find_test_files(self, file_path: str, nodes: List[Dict]) -> List[str]:
         return test_files
 
 
-    # ===== SUPABASE CACHING =====
-    
+    # SUPABASE CACHING
     def save_to_cache(self, repo_id: str, graph_data: Dict):
         """Save dependency graph to Supabase for caching"""
         from services.supabase_service import get_supabase_service

backend/services/indexer_optimized.py

@@ -27,7 +27,6 @@
 
 # Utils
 import hashlib
-from dotenv import load_dotenv
 import time
 
 # Search enhancement
@@ -39,8 +38,6 @@
 # Observability
 from services.observability import logger, trace_operation, track_time, capture_exception, add_breadcrumb, metrics
 
-load_dotenv()
-
 # Configuration
 # Note: If using existing Pinecone index, match the dimension (1536 for small, 3072 for large)
 EMBEDDING_MODEL = os.getenv("EMBEDDING_MODEL", "text-embedding-3-small")

backend/services/observability.py

@@ -30,9 +30,7 @@ async def index_repo(repo_id: str):
 LOG_LEVEL = os.getenv("LOG_LEVEL", "INFO" if IS_PRODUCTION else "DEBUG")
 
 
-# =============================================================================
 # STRUCTURED LOGGER
-# =============================================================================
 
 class StructuredLogger:
     """
@@ -112,9 +110,7 @@ def critical(self, message: str, **kwargs):
 logger = StructuredLogger()
 
 
-# =============================================================================
 # SENTRY INTEGRATION HELPERS
-# =============================================================================
 
 def set_operation_context(operation: str, **kwargs):
     """
@@ -191,9 +187,7 @@ def capture_message(message: str, level: str = "info", **context):
         pass
 
 
-# =============================================================================
 # PERFORMANCE TRACKING
-# =============================================================================
 
 @contextmanager
 def track_time(operation: str, **tags):
@@ -307,9 +301,7 @@ def sync_wrapper(*args, **kwargs):
     return decorator
 
 
-# =============================================================================
 # SIMPLE METRICS (in-memory counters)
-# =============================================================================
 
 class Metrics:
     """

backend/services/playground_limiter.py

@@ -25,9 +25,7 @@
 from services.sentry import capture_exception
 
 
-# =============================================================================
 # DATA CLASSES
-# =============================================================================
 
 @dataclass
 class PlaygroundLimitResult:
@@ -134,9 +132,7 @@ def _truncate_id(session_id: str) -> str:
         return session_id
 
 
-# =============================================================================
 # MAIN CLASS
-# =============================================================================
 
 class PlaygroundLimiter:
     """
@@ -161,9 +157,7 @@ class PlaygroundLimiter:
         has_repo = limiter.has_indexed_repo(session_token)
     """
 
-    # -------------------------------------------------------------------------
     # Configuration
-    # -------------------------------------------------------------------------
 
     # Rate limits
     SESSION_LIMIT_PER_DAY = 50      # Per device (generous for conversion)
@@ -198,9 +192,7 @@ def __init__(self, redis_client=None):
         """
         self.redis = redis_client
 
-    # -------------------------------------------------------------------------
     # Session Data Methods (#127)
-    # -------------------------------------------------------------------------
 
     def get_session_data(self, session_token: Optional[str]) -> SessionData:
         """
@@ -449,9 +441,7 @@ def create_session(self, session_token: str) -> bool:
             capture_exception(e, operation="create_session")
             return False
 
-    # -------------------------------------------------------------------------
     # Rate Limiting Methods (existing, updated for hash storage)
-    # -------------------------------------------------------------------------
 
     def check_limit(
         self,
@@ -657,9 +647,7 @@ def _check_ip_limit(self, client_ip: str, record: bool) -> Tuple[bool, int]:
             logger.error("IP limit check failed", error=str(e))
             return True, self.IP_LIMIT_PER_DAY  # Fail open
 
-    # -------------------------------------------------------------------------
     # Helper Methods
-    # -------------------------------------------------------------------------
 
     def _get_midnight_utc(self) -> datetime:
         """Get next midnight UTC for reset time."""
@@ -788,9 +776,7 @@ def get_usage_stats(self) -> dict:
             return {"error": str(e), "redis_available": False}
 
 
-# =============================================================================
 # SINGLETON
-# =============================================================================
 
 _playground_limiter: Optional[PlaygroundLimiter] = None