Skip to content

fix: validate response before using repo_id (#207)#208

Merged
DevanshuNEU merged 1 commit into
OpenCodeIntel:mainfrom
DevanshuNEU:fix/207-undefined-repo-id
Jan 12, 2026
Merged

fix: validate response before using repo_id (#207)#208
DevanshuNEU merged 1 commit into
OpenCodeIntel:mainfrom
DevanshuNEU:fix/207-undefined-repo-id

Conversation

@DevanshuNEU

Copy link
Copy Markdown
Collaborator

Summary

Fixes #207 - Frontend was sending /repos/undefined/index when the add repository API call failed.

Changes

  • Check response.ok before parsing JSON response
  • Validate repo_id exists before triggering index endpoint
  • Errors now properly propagate to the catch block with meaningful messages

Before

const data = await response.json()
await fetch(`${API_URL}/repos/${data.repo_id}/index`, { ... })
// If first request fails, data.repo_id = undefined

After

if (!response.ok) {
  const err = await response.json().catch(() => ({}))
  throw new Error(err.detail || 'Failed to add repository')
}

const data = await response.json()
if (!data.repo_id) throw new Error('Missing repo_id in response')

await fetch(`${API_URL}/repos/${data.repo_id}/index`, { ... })

Testing

  • Add repo with invalid URL → should show error toast
  • Add repo exceeding tier limit → should show upgrade message
  • Add valid repo → should work as before

- check response.ok before parsing json
- validate repo_id exists before triggering index
- prevents undefined repo_id in API calls
@vercel

vercel Bot commented Jan 12, 2026

Copy link
Copy Markdown

@DevanshuNEU is attempting to deploy a commit to the Dev's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Jan 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
opencodeintel Ready Ready Preview, Comment Jan 12, 2026 10:14pm

@DevanshuNEU DevanshuNEU merged commit 86ef9c9 into OpenCodeIntel:main Jan 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend sends undefined repo_id when add_repo API fails

1 participant