fix: resolve Python dotted imports in dependency analyzer#209
Merged
Conversation
Bug: imports like 'starlette.exceptions' were treated as external because early return checked for '/' but not '.' in import path Fix: only treat single-word imports (os, json) as external Allow dotted imports to reach resolution logic that converts 'starlette.exceptions' → 'starlette/exceptions.py'
|
@DevanshuNEU is attempting to deploy a commit to the Dev's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Python imports like
starlette.exceptionswere being treated as external dependencies, resulting in 0 resolved dependencies even when files existed.Logs showed:
Root Cause
Early return in
_resolve_import_to_filechecked for/in import path but not.:Fix
Only treat single-word imports (os, json, sys) as external. Allow dotted imports to reach resolution logic that converts
starlette.exceptions→starlette/exceptions.py.Test Results
starlette.exceptionsNone❌starlette/exceptions.py✅osNone✅None✅