chore: delete 1726 lines of dead code, scripts, and config duplication (OPE-95, OPE-73)#257
Conversation
…nd duplication Deleted: - 9 dev-only benchmark scripts (1589 lines) -- search quality experiments from v2/v3 sprint. In git history if needed. - backend/.env.example (96 lines) -- duplicate of root, was out of sync. Root .env.example updated with 5 missing vars. - config/api.py dead code (36 lines) -- LEGACY_API_PREFIX, DEPRECATION_HEADER, get_versioned_prefix(), get_legacy_prefix(), is_legacy_route(). None were imported anywhere. Cleaned: - routes/__init__.py: removed stale auth_router export that nobody imports (main.py imports directly from routes.auth). - .gitignore: added .coverage, htmlcov/, .pytest_cache/. - .env.example: added GITHUB_CLIENT_ID/SECRET, FRONTEND_URL, DISCORD_FEEDBACK_WEBHOOK, SENTRY_SEND_PII, SENTRY_INCLUDE_LOCAL_VARS. Net: 14 files changed, -1726 lines. 284 tests pass. Closes OPE-95, OPE-73
|
@DevanshuNEU is attempting to deploy a commit to the Dev's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis PR removes search V3 benchmark and test scripts from the backend, consolidates environment configuration to a root Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.env.example:
- Around line 49-53: Dotenv-linter flags the key ordering and the unquoted
ENVIRONMENT value; reorder the SENTRY_* and ENVIRONMENT entries to follow the
project's .env alphabetical ordering (e.g., place SENTRY_DSN,
SENTRY_INCLUDE_LOCAL_VARS, SENTRY_SEND_PII in correct sorted order) and quote
the ENVIRONMENT value (change ENVIRONMENT=development to
ENVIRONMENT="development") so the linter no longer reports ordering/quoting
warnings for the SENTRY_DSN, SENTRY_SEND_PII, SENTRY_INCLUDE_LOCAL_VARS, and
ENVIRONMENT keys.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
.env.example.gitignorebackend/.env.examplebackend/config/api.pybackend/routes/__init__.pybackend/scripts/benchmark_search_v3.pybackend/scripts/cross_repo_test.pybackend/scripts/edge_case_test.pybackend/scripts/extended_query_test.pybackend/scripts/extended_v3_test.pybackend/scripts/final_v3_test.pybackend/scripts/human_query_test.pybackend/scripts/manual_ws_test.pybackend/scripts/validate_cohere_rerank.py
💤 Files with no reviewable changes (11)
- backend/scripts/benchmark_search_v3.py
- backend/scripts/human_query_test.py
- backend/scripts/extended_v3_test.py
- backend/scripts/validate_cohere_rerank.py
- backend/.env.example
- backend/scripts/edge_case_test.py
- backend/config/api.py
- backend/scripts/final_v3_test.py
- backend/scripts/cross_repo_test.py
- backend/scripts/manual_ws_test.py
- backend/scripts/extended_query_test.py
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
What
Pure deletion PR. Removes dead code, unused scripts, and config duplication. Zero logic changes.
Deleted (1726 lines)
Cleaned
Impact
14 files changed. Net -1726 lines. 284 tests pass. Cleaner repo tree for open source first impressions.
Closes OPE-95, OPE-73
Summary by CodeRabbit
New Features
Chores