Merged
Conversation
Unable to test this locally since that's not something github actions supports.
thirtytwobits
force-pushed
the
issue/171
branch
from
b1fcc97 to
b361773
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SonarQube GitHub Action configuration to address issue #171. The changes modernize the SonarQube integration by switching from using the deprecated SonarCloud C++ action to the newer SonarQube scan action, along with updates to coverage report generation and configuration.
- Replaces the deprecated SonarCloud C++ GitHub Action with the newer SonarQube scan action (v5.3.0)
- Updates coverage report format from SonarQube XML to Cobertura XML format
- Adds missing include files to the sonar.cpp test file for better code coverage analysis
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/cetlvast.yml | Replaces deprecated SonarCloud action with SonarQube scan action and updates workflow configuration |
| cetlvast/cmake/modules/Findgcovr.cmake | Changes coverage report format from --sonarqube to --cobertura |
| cetlvast/cmake/modules/FindSonarScanner.cmake | Updates SonarQube configuration parameters and token handling |
| cetlvast/suites/unittest/CMakeLists.txt | Fixes variable names and removes obsolete exclusion patterns |
| cetlvast/suites/unittest/sonar.cpp | Adds comprehensive include statements for CETL library headers |
| cetlvast/cmake/modules/FindTestReport.cmake | Adds base directory support for test report generation |
| cetlvast/CMakePresets.json | Removes SonarCloud scan targets and adds new manual coverage preset |
| cetlvast/CMakePresetsVendorTemplate.json | Removes SonarCloud scan target from vendor template |
| .vscode/settings.json | Removes hardcoded build directory setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thirtytwobits
added
the
infrastructure
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unable to test this locally since that's not something github actions supports.