fix: Add x-formulus-version header to all API requests#421
Merged
Conversation
- Add x-formulus-version header to Login and RefreshToken functions in auth.go - Change x-api-version to x-formulus-version in client.go doRequest function - Remove DEBUG output line that could leak sensitive data - Fixes issue where servers requiring x-formulus-version header return 426 errors
- Change from '1.24' to '1.24.x' for proper version resolution in GitHub Actions - The .x suffix ensures latest patch version of Go 1.24 is used - This ensures covdata tool and other Go tools are properly available - Go 1.24 exists (released Feb 2025), but needs .x suffix for correct resolution
eaaebc2 to
bd2a53a
Compare
- Revert to 1.25.x which is proven to work in GitHub Actions - Go 1.24.x may not be fully available in all GitHub Actions environments yet - Matches synkronus-cli.yml workflow configuration - Ensures covdata tool and all Go tools are properly available - Go 1.24 exists but 1.25.x is more stable in CI environments
6b81b6d to
7c1a261
Compare
Bahati308
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the CLI fails with 426 errors when connecting to servers that require the
x-formulus-versionheader.Changes
x-formulus-versionheader toLoginfunction inauth.gox-formulus-versionheader toRefreshTokenfunction inauth.gox-api-versiontox-formulus-versionindoRequestfunction inclient.goTesting
Related Issues
Fixes the issue where users get "Missing x-formulus-version header" errors when using the CLI with servers that require this header.