Skip to content

Improvements#19

Merged
g4bri3lDev merged 2 commits into
OpenDisplay:mainfrom
LordMike:feature/cleanups
May 12, 2026
Merged

Improvements#19
g4bri3lDev merged 2 commits into
OpenDisplay:mainfrom
LordMike:feature/cleanups

Conversation

@LordMike

@LordMike LordMike commented May 7, 2026

Copy link
Copy Markdown
Contributor

This is my scratchpad for minor improvements. I'll log them as I make them.

ab01050 - Add discovered tag UX

The first thing I see is the add dialog, it holds blank fields for my OD device, which are only populated when we're working with OEPL/ATC devices. I've split the text in two, so we now see relevant fields. Note the page title is also updated, since this is the OD integration, not a "BLE Tag" integration.

Old layout:
image

New:
image

d638eb3 - Low-risk cleanup

This bundles a set of small, localized cleanup fixes:

  • Removed invalid @callback annotations from async coordinator handlers.
  • Made service device identifier lookup deterministic.
  • Removed unreachable drawcustom error handling.
  • Reduced duplicate image state writes.
  • Made AP tag firmware version formatting defensive.

@LordMike
LordMike marked this pull request as ready for review May 7, 2026 19:59
@LordMike
LordMike requested a review from g4bri3lDev as a code owner May 7, 2026 19:59
@g4bri3lDev
g4bri3lDev merged commit 9fd175f into OpenDisplay:main May 12, 2026
2 of 3 checks passed
@LordMike
LordMike deleted the feature/cleanups branch May 13, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants