Keep reflectance in float32 when estimating irradiance - #2066
Merged
MJohnson459 merged 1 commit intoAug 11, 2026
Conversation
compute_irradiance returns a numpy float64 scalar on the sun sensor estimate path. Since NumPy 2 dropped value-based casting, dividing the float32 radiance by it promotes the reflectance to float64, which OpenSfM then writes with PREDICTOR=2 instead of the floating point predictor. GDAL rejects that combination on 64 bit samples: RasterioIOError: IMG_0078_1.tif: PREDICTOR=2 is supported on 64 bit samples starting with libtiff > 4.3.0. Coercing the irradiance to a plain float keeps the scalar weakly typed, so the reflectance stays float32 as it did before the NumPy 2 upgrade. Fixes OpenDroneMap#2064
smathermather
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute_irradiancereturns a numpy float64 scalar on the sun sensor estimate path. Since NumPy 2 dropped value-based casting, dividing the float32 radiance by it promotes the reflectance to float64, which OpenSfM then writes with PREDICTOR=2 instead of the floating point predictor. GDAL rejects that combination on 64 bit samples:Coercing the irradiance to a plain float keeps the scalar weakly typed, so the reflectance stays float32 as it did before the NumPy 2 upgrade.
Fixes #2064