Modernize linting setup and add pre-commit checks in CI#671
Draft
Modernize linting setup and add pre-commit checks in CI#671
Conversation
…e-584-enhance-code-linting
- Consolidate linting with ruff, replaces black and extents linting - Additional file checks (case-conflict, docstring-first, mixed-line-ending) - Configure global excludes for build artifacts and cache directories - Enable ruff docstring checking with numpy convention
Ensures consistent checking locally and on GH
Member
|
I remember that @nesnoj expects a larger diff when linting the whole repo. We used black until now - will there be such a large difference in the codebase between ruff and black linting? |
Collaborator
Author
Yes, definitely! Black only covers some aspects of code quality. Furthermore, in this case ruff is configured quite extensively. |
This was referenced Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
This PR modernizes the linting and code quality setup for the project using ruff. It also establishes automated pre-commit checks in CI (new workflow:
.github/workflows/pre-commit.yml) to ensure consistent code quality across all contributions.pip install -e .[dev]) and committing something or runpre-commit run --all-filespostprocessing/andopen_mastr/soap_api/are excluded from the tests as they will be removed soon so there's no need to bother about the code quality right now.Workflow checklist
Automation
Closes #584
PR-Assignee
Reviewer